Restructure RPATH and elf interpreter setting for Java, and add the LIBRARY_PATH to the additional RPATH and separate java awt libs #3583
Conversation
…IBRARY_PATH to the additional RPATH
…kipping it unconditionally
…tching of the RPATH for java now
…y returns something :)
…g extra RPATHS. Also, fix syntax for call to logging
…Also, set bin_lib_subdirs so that also the files in lib/server are patched
|
@casparvl all development is on 5.0 now, can you please move the target of this PR to the branch |
If this can wait a bit, there's no need to, soon the |
| # using patchelf, see e.g. https://github.com/easybuilders/easybuild-easyblocks/pull/3571 | ||
| # The option run_rpath_sanity_check supports a gradual transition where binary installs that properly | ||
| # patch the RPATH can start running the sanity check | ||
| 'run_rpath_sanity_check': [False, "Whether or not to run the RPATH sanity check", CUSTOM], |
There was a problem hiding this comment.
This used to be needed not to break any existing rpath sanity checking that's going on. But, that may no longer be the case: the default RPATH sanity check has been relaxed https://docs.easybuild.io/easybuild-v5/changes/#rpath . So, unless people actively filter LD_LIBRARY_PATH in their Easybuild config, the sanity check wouldn't fail anyway.
| extra_vars.update({ | ||
| # Overwrite the default value for run_rpath_sanity_check to True, since we have RPATH patching with | ||
| # patchelf for Java | ||
| 'run_rpath_sanity_check': [True, "Whether or not to run the RPATH sanity check", CUSTOM], |
There was a problem hiding this comment.
can (probably) be removed, see above.
3 participants
Supersedes #3571