-
Notifications
You must be signed in to change notification settings - Fork 307
Fix building PyTorch when using setup.py as the build command
#3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When changing `use_pip` after `PythonPackage.__init__` called `determine_install_command` the change is not honored. Call it again after the change. This also requires to make it idempotent so all member variables changed in that function need to be set in all cases. Fixes easybuilders#3570
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
PyTorch test failed in test step with: I was also testing with the wrong easyconfig, because |
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2676733731 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
When changing
use_pipafterPythonPackage.__init__calleddetermine_install_commandthe change is not honored. Call it again after the change.This also requires to make it idempotent so all member variables changed in that function need to be set in all cases.
Fixes #3570