Update easyblocks to use EasyConfig.parallel property
#3557
Conversation
Flamefire
force-pushed
the
parallel_prop
branch
from
0bafa27 to
c0bdf64
Compare
|
I prepared a list file of ECs changed in easybuilders/easybuild-easyconfigs#19375 that are still in 5.0x to test this with which I'm currently doing over the next 3 days (some downtime here) |
Don't use the deprecated `ec['parallel']` value anymore. Introduce a property to `ConfigureMake` to get the commonly used `-j <n>` string. Verify each use converting them to fStrings.
Flamefire
force-pushed
the
parallel_prop
branch
from
c0bdf64 to
6f0d056
Compare
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
test checkboard:
|
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
@Flamefire Perl fails with |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
GCCcore failures: Doesn't seem to be caused by this. Can you try without this PR in the same environment? |
I fear there is some larger underlying issue: Extensions can set |
|
I added a new commit to the framework PR that should fix the Perl build |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
GCC fail was a local issue due to the special RPATH processing we do, I just rebuilt with |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Thanks, it works now! |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
There was another fix required for ECs using extensions with |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
yes Bazel doesn't like it when I have the rpath wrappers or ccache enabled. It may be something specific to our environment, not related to your PR |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 8 (8 easyconfigs in total) |
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 80 out of 82 (82 easyconfigs in total) |
|
Pretty much all ECs changed in the parallel easyconfigs PR passed.
|
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 18 out of 18 (17 easyconfigs in total) |
boegel
dismissed
bartoldeman’s stale review
typo in OpenBLAS easyblock was fixed
3 participants
Don't use the deprecated
ec['parallel']value anymore.Introduce a property to
ConfigureMaketo get the commonly used-j <n>string.Verify each use converting them to fStrings. Partially because it makes it easier to read but also to let me verify I had checked every place where it is used.
Requires
paralleleasyconfig parameter and fix updating the template value easybuild-framework#4580