Skip to content

Conversation

@beeebiii
Copy link

@beeebiii beeebiii commented Sep 4, 2024

Hi, as discussed in Slack, and being based in in these three PRs:
easybuilders/easybuild-easyconfigs#17718
#2349
#2918
I have written easyblock for CP2K, during the compilation of **CP2K-2024.2-foss-2023a-CUDA-12.2.0.eb **. Almost all the tests pass except for around 50 tests of total 4000 tests fail.

@boegel boegel changed the title This is the cp2k.py(Easyblock) that i have written being based on PR(2918) update custom easyblock for CP2K >= v2024 Sep 11, 2024
@boegel boegel added the update label Sep 11, 2024
Copy link
Contributor

@gkaf89 gkaf89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification relevant, fix CUDA builds. Tested with CP2K 2024.3 with and without CUDA (12.1.1 with gpuver=V100).

if cp2k_version >= LooseVersion('2024'):
options['DFLAGS'] += ' -D__OFFLOAD_CUDA -D__DBCSR_ACC '
options['LIBS'] += ' -lcufft -lcudart -lnvrtc -lcuda -lcublas'
options['OFFLOAD_CC'] = 'nvcc'
Copy link
Contributor

@gkaf89 gkaf89 Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OFFLOAD_CC variable is used in the makefile of CP2K to build files with OpenACC offloading, even in versions older than 2024. For instance 2023.1 fails to build with CUDA support with the old easyblock.

Maybe enable the modification for some versions earlier than 2024 if they are still relevant?

Copy link
Author

@beeebiii beeebiii Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it can surely be modified, but i have not tested them with old versions, when i test them will definitely modify if required. Thanks!!

@beeebiii
Copy link
Author

Tested it on two of the clusters with (gpuver=A100 and gpuver=H100) worked without any issues.

@pavelToman
Copy link
Contributor

@boegelbot please test @ jsc-zen3 EB_ARGS="CP2K-2023.1-foss-2023a.eb"

@boegelbot
Copy link

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3433 EB_ARGS="CP2K-2023.1-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3433 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7560

Test results coming soon (I hope)...

- notification for comment with ID 3179512569 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c3.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/c96073f72577f0f07166819427668ca8 for a full test report.

@pavelToman
Copy link
Contributor

@boegelbot please test @ jsc-zen3 EB_ARGS="CP2K-2023.1-foss-2023a.eb"

@boegelbot
Copy link

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3433 EB_ARGS="CP2K-2023.1-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3433 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7581

Test results coming soon (I hope)...

- notification for comment with ID 3184071272 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7c4ace739078eb00fb845e4ebd9ead30 for a full test report.

@pavelToman
Copy link
Contributor

pavelToman commented Aug 13, 2025

Test report by @boegelbot

Overview of tested easyconfigs (in order)

* **FAIL (build issue)** _CP2K-2023.1-foss-2023a.eb_ (partial log available at https://gist.github.com/boegelbot/0b8a5f90d095e57e3bd6458a2c05ec33)

Build succeeded for 0 out of 1 (1 easyconfigs in total) jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21 See https://gist.github.com/boegelbot/7c4ace739078eb00fb845e4ebd9ead30 for a full test report.

It never populates INCS with LIBXSMM for CP2K 2023.x -> failed on build
I'm gonna fix it in: #3888

@pavelToman
Copy link
Contributor

pavelToman commented Aug 14, 2025

This PR is replaced by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants