Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 6, 2024

The extract step accesses self.crates but that is not set when the 'crates' key in the EasyConfig is not set yielding

AttributeError: 'CargoPythonPackage' object has no attribute 'crates'

While this usecase is rare and might not make much sense we shouldn't crash so initialize this property to an empty list.

@Flamefire
Copy link
Contributor Author

Flamefire commented Aug 7, 2024

Test report by @Flamefire

Overview of tested easyconfigs (in order)

CargoPythonPackage
  • SUCCESS bcrypt-4.1.3-GCCcore-13.2.0.eb
  • SUCCESS tiktoken-0.7.0-GCCcore-12.3.0.eb
CargoPythonBundle
  • SUCCESS jiter-0.4.1-GCCcore-12.3.0.eb
  • SUCCESS pydantic-2.7.4-GCCcore-13.2.0.eb
Cargo
  • SUCCESS SKA2-0.3.7-GCCcore-12.2.0.eb
  • SUCCESS ripunzip-0.4.0.eb
  • SUCCESS alevin-fry-0.9.0-GCCcore-13.2.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
i7024 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/104721135e3f9c427bfbd39dc2454759 for a full test report.

@boegel boegel added the bug fix label Aug 14, 2024
@boegel boegel added this to the release after 4.9.2 milestone Aug 14, 2024
@boegel
Copy link
Member

boegel commented Aug 14, 2024

@Flamefire Please sync with develop now #3406 is merged?

The extract step accesses `self.crates` but that is not set when the
'crates' key in the EasyConfig is not set yielding
> AttributeError: 'CargoPythonPackage' object has no attribute 'crates'

While this usecase is rare and might not make much sense we shouldn't
crash so initialize this property to an empty list.
@Flamefire
Copy link
Contributor Author

Done but might need new tests as I removed the reset of self.cfg['crates'] which shouldn't be required anymore.

I tested with easybuilders/easybuild-easyconfigs#21143 for a dummy state representing a PR of possibly affected ECs

The double-init issue is fixed
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 30, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS cryptography-42.0.8-GCCcore-13.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/221bbe83fc1941d0b350b0020d17f2d4 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 30, 2024

I tested with offline = False and no crates and it worked.

@Micket Micket merged commit cc5b95d into easybuilders:develop Aug 30, 2024
@Flamefire Flamefire deleted the cargocrash branch August 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants