-
Notifications
You must be signed in to change notification settings - Fork 305
fix crash in Cargo easyblock when no crates are specified #3404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
|
|
@Flamefire Please sync with |
The extract step accesses `self.crates` but that is not set when the 'crates' key in the EasyConfig is not set yielding > AttributeError: 'CargoPythonPackage' object has no attribute 'crates' While this usecase is rare and might not make much sense we shouldn't crash so initialize this property to an empty list.
|
Done but might need new tests as I removed the reset of I tested with easybuilders/easybuild-easyconfigs#21143 for a dummy state representing a PR of possibly affected ECs |
The double-init issue is fixed
Micket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
I tested with |
The extract step accesses
self.cratesbut that is not set when the 'crates' key in the EasyConfig is not set yieldingWhile this usecase is rare and might not make much sense we shouldn't crash so initialize this property to an empty list.
CargobyCargoPythonPackageby removing incorrect custom__init__implementation + fix use ofsuper()in PALM easyblock (since that doesn't work with Python 2.7) #3406