-
Notifications
You must be signed in to change notification settings - Fork 305
fix extra $PATH entry for OCaml to use opam/default rather than opam/system
#3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
bartoldeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
default rather than system
default rather than system$PATH entry for OCaml to use opam/default rather than opam/system
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@branfosj Let's add "ocamlfind list" as sanity check command to catch this bug?
Maybe that should only be done conditionally though, when ocamlfind is being installed as extension?
|
@boegelbot please test @ jsc-zen3 |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2287170284 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
$PATH entry for OCaml to use opam/default rather than opam/system$PATH entry for OCaml to use opam/default rather than opam/system
For
OCaml/5.1.1-GCC-13.2.0on generoso and forOCaml/4.14.0-GCC-11.3.0on my system there is noopam/systembut there isopam/defaultand this containsocamlfind