deprecate unknown configure args in ConfigureMake easyblock - #3026
Closed
Flamefire wants to merge 3 commits into
Closed
deprecate unknown configure args in ConfigureMake easyblock#3026Flamefire wants to merge 3 commits into
ConfigureMake easyblock#3026Flamefire wants to merge 3 commits into
Conversation
84 tasks
Member
|
This makes sense to include in EasyBuild 4.x, but we should still try and do a sweep across all easyconfigs using That's a huge list of easyconfigs, so it's a pretty painful exercise, but a necessary one imho, unless we're willing to accept exposing people to these warnings (which may help in getting the problems fixed, I guess). |
Contributor
Author
I'd opt for the latter. I actually run the EasyBlock which fails hard instead on our cluster such that those things actually make me fix it. A scary warning to convince more people to cleanup the ECs sounds like a good compromise to get this big task done. Doing a bulk fix is going to be hard as even though you can use |
Member
|
I did a quick scan for " Most of these were done as a part of the regression test for EasyBuild v4.8.2, so recent installations, but some are older (marked with
Although not a blocker for merging this PR, it would be good to have these easyconfigs updated so the warning won't present itself when installing these... |
Contributor
Author
|
I checked my recent tree and also found the Tcl issue. However it looks like it is some configure called by configure passing those flags as we only do |
Member
|
I did a scan for " |
Contributor
Author
|
That's quite a few and we may want to fix them (for the non-ancient and at least easy ones) for EB 5. But: Do we still need to consider/handle EB 4.x PRs after 4.9.0 was released? |
Contributor
Author
|
@boegel I compiled as list of EC filenames from your 2 comments and mentioned in #3025 and am running tests building those using develop. The resulting PRs should be all findable by https://github.com/easybuilders/easybuild-easyconfigs/pulls?q=is%3Apr+author%3AFlamefire++configure |
This was referenced Feb 29, 2024
Merged
Merged
Flamefire
marked this pull request as draft
March 8, 2024 08:03
Contributor
Author
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 75 out of 75 (75 easyconfigs in total) |
Flamefire
marked this pull request as ready for review
March 11, 2024 08:07
Contributor
Author
|
@boegel The above test report was done with a temporary change to issue an error instead of a warning. As you can see all ECs you identified are now fixed. So I'd say this is ready now. |
Flamefire
force-pushed
the
configuremake_warn
branch
from
August 8, 2024 07:25
4294ae0 to
70a582e
Compare
Member
|
We're going with the harder approach in #3025 for EasyBuild 5.0, so closing this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More compatible version of #3025 for 4.x to only deprecate and verbosely warn about unknown configure args