Skip to content

call parent post_install_step in EasyBuildMeta easyblock (so postinstallcmds are taken into account) #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 2 commits into from
Feb 23, 2023
Merged

call parent post_install_step in EasyBuildMeta easyblock (so postinstallcmds are taken into account) #2893

boegel merged 2 commits into from
Feb 23, 2023

Conversation

@fgonzalez-DoItNow
Copy link

@fgonzalez-DoItNow fgonzalez-DoItNow commented Feb 22, 2023

No description provided.

@boegel boegel added this to the next release (4.7.1?) milestone Feb 23, 2023
@boegel
Copy link
Member

boegel commented Feb 23, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.7.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3127.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/4b60655111616bcc4db33272823642cd for a full test report.

@boegel boegel changed the title Adding support for postinstallcmds in easybuildmeta call parent post_install_step in EasyBuildMeta easyblock (so postinstallcmds are taken into account) Feb 23, 2023
boegel
boegel approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 6e4255e into easybuilders:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@fgonzalez-DoItNow @boegel