Skip to content

avoid crash in test step of PyTorch easyblock if runtest is not a command #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 3 commits into from
Mar 3, 2023
Merged

avoid crash in test step of PyTorch easyblock if runtest is not a command #2883

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84c5610
void pytorch test_step crashing if runtest is not a command
akesandgren Feb 9, 2023
0a8ebd2
test return from super(EB_PyTorch, self).test_step and handle the res…
akesandgren Feb 9, 2023
8fff3f6
reverse test of runtest and clarify error message.
akesandgren Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion easybuild/easyblocks/p/pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,15 @@ def test_step(self):
'excluded_tests': ' '.join(excluded_tests)
})

tests_out, tests_ec = super(EB_PyTorch, self).test_step(return_output_ec=True)
test_result = super(EB_PyTorch, self).test_step(return_output_ec=True)
if test_result is None:
if self.cfg['runtest'] is False:
msg = "Do not set 'runtest' to False, use --skip-test-step instead."
else:
msg = "Tests did not run. Make sure 'runtest' is set to a command."
raise EasyBuildError(msg)

tests_out, tests_ec = test_result

def get_count_for_pattern(regex, text):
"""Match the regexp containing a single group and return the integer value of the matched group.
Expand Down