Skip to content

fix error when failing pip version check during PythonPackage sanity check #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Feb 15, 2023
Merged

fix error when failing pip version check during PythonPackage sanity check #2877

boegel merged 1 commit into from
Feb 15, 2023

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 6, 2023

The arguments must be passed individually not as a tuple, else you get:

File "/easybuild-easyblocks/easybuild/easyblocks/generic/pythonpackage.py", line 921, in sanity_check_step
pip_version))
File "/easybuild-framework/easybuild/tools/build_log.py", line 81, in init
msg = msg % args
TypeError: not enough arguments for format string

@boegel This should go into next release.

@Flamefire
Fix error when failing PIP version check during PythonPackage sanity …
ebd7392 
…check.

The arguments must be passed individually not as a tuple, else you get:
>   File "/easybuild-easyblocks/easybuild/easyblocks/generic/pythonpackage.py", line 921, in sanity_check_step
>     pip_version))
>   File "/easybuild-framework/easybuild/tools/build_log.py", line 81, in __init__
>     msg = msg % args
> TypeError: not enough arguments for format string
@boegel boegel added the bug fix label Feb 15, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 15, 2023
boegel
boegel approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix error when failing PIP version check during PythonPackage sanity check fix error when failing PIP version check during PythonPackage sanity check Feb 15, 2023
@boegel
Copy link
Member

boegel commented Feb 15, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS matplotlib-3.5.2-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3113.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/42f238228166b09d6d92d8c3a8497779 for a full test report.

@boegel boegel merged commit 40158d1 into easybuilders:develop Feb 15, 2023
@Flamefire Flamefire deleted the fix-pythonpkg-sanitycheck branch February 15, 2023 17:02
@lexming lexming mentioned this pull request Feb 21, 2023
Closed
@boegel boegel changed the title fix error when failing PIP version check during PythonPackage sanity check fix error when failing pip version check during PythonPackage sanity check Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel