Fix missing initialization of CMakeMake in CMakePythonPackage #2876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)The
CMakeMakeeasyblock does some initialization in its__init__method which get skipped byCMakePythonPackageas that only initializes thePythonPackageclass.That is wrong as changes to the CMakeMake easyblock will be missed if not manually added as done before with
self._lib_ext = None.I observed an actual failure caused by this when testing #2838 which adds another member variable in its init and then e.g.
GenomeWorks-2021.02.2-fosscuda-2020b.ebfails withThis fixes it by simply removing the custom (incomplete)
__init__function. Now the build succeeds.