Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 2, 2023

(created using eb --new-pr)

When exts_default_options is logged the templating is already re-enabled. This means any template in that log entry will be resolved using the parent EC values not the ones that will actually be used by extensions.

Fix this by moving the print inside the disable-template section and use the context manager while at it.

@boegel boegel added the bug fix label Feb 15, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 15, 2023
@smoors
Copy link
Contributor

smoors commented Mar 3, 2023

tested with random pythonbundle easyconfig (wandb), fixes the issue.

relevant log line including exts_default_options:
original

== 2023-02-28 21:21:10,855 pythonbundle.py:79 INFO exts_default_options: {'buildcmd': None, 'check_ldshared': None, 'download_dep_fail': True, 'install_src': None, 'install_tar
get': 'install', 'pip_ignore_installed': True, 'pip_no_index': None, 'req_py_majver': None, 'req_py_minver': None, 'sanity_pip_check': True, 'runtest': True, 'testinstall': Fal
se, 'unpack_sources': None, 'unversioned_packages': [], 'use_pip': True, 'use_pip_editable': False, 'use_pip_extras': None, 'use_pip_for_deps': False, 'use_pip_requirement': Fa
lse, 'zipped_egg': False, 'source_urls': ['https://pypi.python.org/packages/source/w/wandb'], 'options': {}}

with this PR:

== 2023-03-03 22:59:38,840 pythonbundle.py:75 INFO exts_default_options: {'buildcmd': None, 'check_ldshared': None, 'download_dep_fail': True, 'install_src': None, 'install_tar
get': 'install', 'pip_ignore_installed': True, 'pip_no_index': None, 'req_py_majver': None, 'req_py_minver': None, 'sanity_pip_check': True, 'runtest': True, 'testinstall': Fal
se, 'unpack_sources': None, 'unversioned_packages': [], 'use_pip': True, 'use_pip_editable': False, 'use_pip_extras': None, 'use_pip_for_deps': False, 'use_pip_requirement': Fa
lse, 'zipped_egg': False, 'source_urls': ['https://pypi.python.org/packages/source/%(nameletter)s/%(name)s'], 'options': {}}

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Mar 3, 2023

Going in, thanks @Flamefire!

@smoors smoors merged commit 839cdea into easybuilders:develop Mar 3, 2023
@Flamefire Flamefire deleted the 20230202134231_new_pr_pythonbundle branch March 4, 2023 12:52
@boegel boegel changed the title Show template values of exts_default_options in PythonBundle show template values of exts_default_options in PythonBundle Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants