Skip to content

use python -m pip instead of pip in PythonPackage easyblock #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 2 commits into from
Oct 19, 2022
Merged

use python -m pip instead of pip in PythonPackage easyblock #2807

boegel merged 2 commits into from
Oct 19, 2022

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented Oct 18, 2022

This is motivated by changes required in #2805 where (due to environment variables like EB_PYTHON) the "correct" pip command may not even be in the users path.

@ocaisa
Copy link
Member Author

ocaisa commented Oct 18, 2022

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS networkx-2.4-foss-2020a-Python-3.8.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
gpunode1.int.eessi-gpu.learnhpc.eu - Linux Rocky Linux 8.5 (Green Obsidian), x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.9.13
See https://gist.github.com/e4678ff0c8473dbdb7e177edc1021e23 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Oct 18, 2022

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS dm-reverb-0.2.0-foss-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
gpunode1.int.eessi-gpu.learnhpc.eu - Linux Rocky Linux 8.5 (Green Obsidian), x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.9.13
See https://gist.github.com/e70db8823fde0ad0173e07680be17026 for a full test report.

ocaisa
ocaisa commented Oct 18, 2022
View reviewed changes
easybuild/easyblocks/d/dm_reverb.py
bazel_build_opts += " --subcommands"

bazel_cmd = "bazel %s build %s %s" % (bazel_opts, bazel_build_opts, bazel_build_pkg)
bazel_cmd = "%s bazel %s build %s %s" % (self.cfg['prebuildopts'], bazel_opts, bazel_build_opts,
Copy link
Member Author

@ocaisa ocaisa Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix I needed to allow me to get around EESSI/software-layer#192 which affects this package.

@boegel boegel changed the title Prefer python -m pip over pip for Python packages use python -m pip instead of pip in PythonPackage easyblock Oct 18, 2022
@boegel boegel added this to the next release (4.6.2?) milestone Oct 18, 2022
@boegel boegel mentioned this pull request Oct 18, 2022
Merged
@boegel
Copy link
Member

boegel commented Oct 19, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Biopython-1.79-foss-2022a.eb
  • SUCCESS Seaborn-0.11.2-foss-2021b.eb
  • SUCCESS h5py-3.6.0-intel-2021b.eb
  • SUCCESS DyMat-0.7-foss-2021b-2020-12-12.eb
  • SUCCESS pyBigWig-0.3.18-foss-2021a.eb
  • SUCCESS AlphaFold-2.2.2-foss-2021a.eb
  • SUCCESS SunPy-1.1.3-foss-2019b-Python-3.7.4.eb
  • SUCCESS netcdf4-python-1.5.3-foss-2019b-Python-2.7.16.eb
  • SUCCESS matplotlib-2.2.5-foss-2020b-Python-2.7.18.eb
  • SUCCESS matplotlib-3.5.1-foss-2020b.eb
  • SUCCESS numexpr-2.8.1-foss-2021a.eb
  • SUCCESS SEPP-4.5.1-foss-2021b.eb
  • SUCCESS pybind11-2.9.2-GCCcore-11.3.0.eb
  • SUCCESS Zip-3.0-GCCcore-10.2.0.eb
  • SUCCESS bokeh-2.2.3-intel-2020b.eb
  • SUCCESS Bazel-3.7.2-GCCcore-10.2.0.eb
  • SUCCESS dask-2021.2.0-intel-2020b.eb
  • SUCCESS scikit-image-0.18.1-intel-2020b.eb
  • SUCCESS protobuf-3.14.0-GCCcore-10.2.0.eb
  • SUCCESS flatbuffers-1.12.0-GCCcore-10.2.0.eb
  • SUCCESS giflib-5.2.1-GCCcore-10.2.0.eb
  • SUCCESS JsonCpp-1.9.4-GCCcore-10.2.0.eb
  • SUCCESS nsync-1.24.0-GCCcore-10.2.0.eb
  • SUCCESS protobuf-python-3.14.0-GCCcore-10.2.0.eb
  • SUCCESS flatbuffers-python-1.12-GCCcore-10.2.0.eb
  • SUCCESS TensorFlow-2.4.1-foss-2020b.eb
  • SUCCESS dm-reverb-0.2.0-foss-2020b.eb

Build succeeded for 27 out of 27 (15 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/02977aa8b710db512a2ce835f4c19211 for a full test report.

boegel
boegel approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 73149f8 into easybuilders:develop Oct 19, 2022
@boegel boegel mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@ocaisa @boegel