Skip to content

enhance PythonPackage easyblock to make sure all test command output makes it to the EasyBuild log, also when return_output_ec=True #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 2 commits into from
Aug 6, 2022
Merged

enhance PythonPackage easyblock to make sure all test command output makes it to the EasyBuild log, also when return_output_ec=True #2770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4e405f
Make sure all output makes it to the EasyBuild log, also when return_…
Aug 5, 2022
f075a66
Used double quotes for sentence, no longer used % for log statement
Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions easybuild/easyblocks/generic/pythonpackage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,8 @@ def test_step(self, return_output_ec=False):

if return_output_ec:
(out, ec) = run_cmd(cmd, log_all=False, log_ok=False, simple=False)
# need to log seperately, since log_all and log_ok need to be false to retreive out and ec
self.log.info("cmd '%s' exited with exit code %s and output:\n%s", cmd, ec, out)
else:
run_cmd(cmd, log_all=True, simple=True)

Expand Down