Skip to content

replace hardcoded /tmp to make sure that Bazel build respects $TMPDIR #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Mar 29, 2022
Merged

replace hardcoded /tmp to make sure that Bazel build respects $TMPDIR #2703

boegel merged 1 commit into from
Mar 29, 2022

Conversation

@jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Mar 28, 2022 •
edited
Loading

Affects all Bazel versions 0.3.1 and newer. PR also made upstream bazelbuild/bazel#15129

(created using eb --new-pr)

@jfgrimm jfgrimm changed the title Ensure Bazel respects Ensure Bazel respects $TMPDIR Mar 28, 2022
@jfgrimm jfgrimm mentioned this pull request Mar 28, 2022
Closed
@branfosj
Copy link
Member

branfosj commented Mar 28, 2022

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Bazel-0.18.0-GCCcore-7.3.0.eb
  • SUCCESS Bazel-0.20.0-GCCcore-7.3.0.eb
  • SUCCESS Bazel-0.20.0-GCCcore-8.2.0.eb
  • SUCCESS Bazel-0.25.2-GCCcore-8.2.0.eb
  • SUCCESS Bazel-0.26.1-GCCcore-8.2.0.eb
  • SUCCESS Bazel-0.26.1-GCCcore-8.3.0.eb
  • SUCCESS Bazel-0.29.1-GCCcore-8.2.0.eb
  • SUCCESS Bazel-0.29.1-GCCcore-8.3.0.eb
  • SUCCESS Bazel-0.29.1-GCCcore-9.3.0-Java-1.8.eb
  • SUCCESS Bazel-1.1.0-GCCcore-8.3.0.eb
  • SUCCESS Bazel-2.0.0-GCCcore-10.2.0.eb
  • SUCCESS Bazel-2.0.0-GCCcore-8.3.0.eb
  • SUCCESS Bazel-3.4.1-GCCcore-8.3.0.eb
  • SUCCESS Bazel-3.6.0-GCCcore-9.3.0.eb
  • SUCCESS Bazel-3.7.1-GCCcore-8.3.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-10.2.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-10.3.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-11.2.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-8.3.0.eb

Build succeeded for 19 out of 19 (19 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/ed450eeb8919684a2e25ac60fb7ad887 for a full test report.

@boegel boegel changed the title Ensure Bazel respects $TMPDIR make sure that Bazel respects $TMPDIR Mar 28, 2022
@boegel boegel changed the title make sure that Bazel respects $TMPDIR replace hardcoded /tmp to make sure that Bazel respects $TMPDIR Mar 28, 2022
@boegel boegel added this to the next release (4.5.4) milestone Mar 28, 2022
@boegel
Copy link
Member

boegel commented Mar 28, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Bazel-0.29.1-GCCcore-9.3.0-Java-1.8.eb
  • SUCCESS Bazel-1.1.0-GCCcore-8.3.0.eb
  • SUCCESS Bazel-2.0.0-GCCcore-10.2.0.eb
  • SUCCESS Bazel-3.6.0-GCCcore-9.3.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-10.2.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-10.3.0.eb
  • SUCCESS Bazel-3.7.2-GCCcore-11.2.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3112.skitty.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/378b02bf40f4ece7876dcecefd6c299a for a full test report.

boegel
boegel approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title replace hardcoded /tmp to make sure that Bazel respects $TMPDIR replace hardcoded /tmp to make sure that Bazel build respects $TMPDIR Mar 29, 2022
@boegel boegel merged commit 6ba5b0f into easybuilders:develop Mar 29, 2022
@boegel boegel mentioned this pull request Mar 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jfgrimm @branfosj @boegel