Skip to content

enhance COMSOL easyblock to change permission on build directory during extract step (to allow using patches) #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Oct 13, 2021
Merged

enhance COMSOL easyblock to change permission on build directory during extract step (to allow using patches) #2584

boegel merged 1 commit into from
Oct 13, 2021

Conversation

@akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Sep 27, 2021 •
edited
Loading

(created using eb --new-pr)

This makes it possible to add "patches" to the COMSOL build.

@akesandgren akesandgren added this to the 4.x milestone Sep 27, 2021
@akesandgren
Copy link
Contributor Author

akesandgren commented Sep 27, 2021

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS COMSOL-5.6.0.401.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/24909c5f3c1641d9378c0784940bb6dd for a full test report.

@akesandgren akesandgren changed the title Fix comsol easyblock to change permission builddir during extract step. Fix comsol easyblock to change permission on builddir during extract step. Sep 27, 2021
@boegel boegel changed the title Fix comsol easyblock to change permission on builddir during extract step. Fix COMSOL easyblock to change permission on builddir during extract step Sep 29, 2021
@boegel boegel changed the title Fix COMSOL easyblock to change permission on builddir during extract step enhance COMSOL easyblock to change permission on build directory during extract step (to allow using patches) Sep 29, 2021
boegel
boegel requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, next release (4.5.0?) Oct 13, 2021
@boegel boegel merged commit eadcd32 into easybuilders:develop Oct 13, 2021
@akesandgren akesandgren deleted the 20210927141625_new_pr_comsol branch October 13, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@akesandgren @boegel