-
Notifications
You must be signed in to change notification settings - Fork 305
make sure custom easyblock for installing EasyBuild respects requested version of Python (like $EB_PYTHON) #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
boegel
merged 4 commits into
easybuilders:develop
from
ocaisa:respect_python_eb_install
Oct 27, 2021
Merged
make sure custom easyblock for installing EasyBuild respects requested version of Python (like $EB_PYTHON) #2581
boegel
merged 4 commits into
easybuilders:develop
from
ocaisa:respect_python_eb_install
Oct 27, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With this fix without the fix we get a failing installation: |
boegel
requested changes
Sep 23, 2021
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
boegel
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes easybuilders/easybuild-framework#3846
This is necessary because if the EB python is, e.g., python3.6 but python3.8 is in the PATH, then 3.8 will be used for the actual installation, causing the sanity check to fail (since it will check for libs in the 3.6 path).