Skip to content

Conversation

@Micket
Copy link
Contributor

@Micket Micket commented Sep 1, 2021

No description provided.

@boegel boegel added the bug fix label Sep 1, 2021
@boegel boegel added this to the 4.4.2 milestone Sep 1, 2021
@Micket Micket changed the title Fix path join bug affecting older CUDA builds. Fix pathsep join bug affecting older CUDA builds. Sep 1, 2021
@Micket Micket changed the title Fix pathsep join bug affecting older CUDA builds. Fix pathsep join bug affecting CUDA builds with PERL5LIB set Sep 1, 2021
@boegel boegel changed the title Fix pathsep join bug affecting CUDA builds with PERL5LIB set fix pathsep join bug that breaks installation of CUDA versions < 10.1 if $PERL5LIB is defined Sep 1, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor Author

Micket commented Sep 1, 2021

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-9.2.88-GCC-7.3.0-2.30.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/d7fd9ab4a3a079cb81028a5bcbdb6f0f for a full test report.

@boegel
Copy link
Member

boegel commented Sep 1, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-9.2.88.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2636.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d61d1885016d6a3f382130a092466f46 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 1, 2021

Easy to reproduce the bug:

$ PERL5LIB=/tmp eb CUDA-9.2.88.eb
...
== installing...
== ... (took < 1 sec)
ERROR: Traceback (most recent call last):
  File "/lib/python2.7/site-packages/easybuild_framework-4.4.2.dev0-py2.7.egg/easybuild/main.py", line 118, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/lib/python2.7/site-packages/easybuild_framework-4.4.2.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 3713, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/lib/python2.7/site-packages/easybuild_framework-4.4.2.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 3601, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/lib/python2.7/site-packages/easybuild_framework-4.4.2.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 3454, in run_step
    step_method(self)()
  File "/lib/python2.7/site-packages/easybuild_easyblocks-4.4.2.dev0-py2.7.egg/easybuild/easyblocks/c/cuda.py", line 176, in install_step
    p5lib = os.pathsep.join(self.builddir, p5lib)
TypeError: join() takes exactly one argument (2 given)

Was introduced in #2387 (so present in EasyBuild 4.4.0 and 4.4.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants