Skip to content

read MATLAB configuration file in binary mode to avoid UTF-8 encoding errors when using Python 3.6 - #2340

Merged
bartoldeman merged 2 commits into
easybuilders:developfrom
boegel:matlab_fix_utf8
Feb 19, 2021
Merged

read MATLAB configuration file in binary mode to avoid UTF-8 encoding errors when using Python 3.6#2340
bartoldeman merged 2 commits into
easybuilders:developfrom
boegel:matlab_fix_utf8

Conversation

@boegel

@boegel boegel commented Feb 18, 2021

Copy link
Copy Markdown
Member

fixes #2329

@boegel boegel added the bug fix label Feb 18, 2021
@boegel boegel added this to the 4.3.3 (next release) milestone Feb 18, 2021
@boegel

boegel commented Feb 19, 2021

Copy link
Copy Markdown
Member Author

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/7131f10dc1b53caafc0238ed7de7063c for a full test report.

@boegel

boegel commented Feb 19, 2021

Copy link
Copy Markdown
Member Author

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/af951c06ce8c8ccd38b279aa1c302eed for a full test report.

@boegel

boegel commented Feb 19, 2021

Copy link
Copy Markdown
Member Author

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2016b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/bed2795a69308ba8786300abbb419d75 for a full test report.

bartoldeman
bartoldeman requested changes Feb 19, 2021
View reviewed changes

@bartoldeman bartoldeman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo

Comment thread easybuild/easyblocks/m/matlab.py Outdated
bartoldeman
bartoldeman approved these changes Feb 19, 2021
View reviewed changes

@bartoldeman bartoldeman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman
bartoldeman merged commit e9c1ef4 into easybuilders:develop Feb 19, 2021
@boegel
boegel deleted the matlab_fix_utf8 branch February 19, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

Matlab fails to build with Python 3

2 participants

@boegel @bartoldeman