fix logic w.r.t. enabling Python support in PETSc #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
branfosj
requested changes
Jan 4, 2021
Member
branfosj
left a comment
branfosj
left a comment
There was a problem hiding this comment.
This has not fully solved the issue due to a bug. My test has:
./configure --prefix=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/PETSc/3.11.0-foss-2018b-downloaded-deps --with-hdf5=1 --with-hdf5-dir=$EBROOTHDF5 --with-debugging --with-cxx-dialect=C++11 --download-hypre=1 --download-ptscotch=1 --download-mumps=1 --download-superlu_dist=1 --download-parmetis=1 --download-triangle=1 --download-suitesparse=1 --download-prometheus=1 --download-metis=1 --download-ml=1 --download-superlu=1 --download-hypre-shared=0 --download-metis-shared=0 --download-ml-shared=0 --download-mumps-shared=0 --download-parmetis-shared=0 --download-prometheus-shared=0 --download-ptscotch-shared=0 --download-suitesparse-shared=0 --download-superlu-shared=0 --download-superlu_dist-shared=0 --with-cc="mpicc" --with-cxx="mpicxx" --with-c++-support --with-fc="mpifort" --CFLAGS="-O2 -ftree-vectorize -march=native -fno-math-errno -fPIC" --CXXFLAGS="-O2 -ftree-vectorize -march=native -fno-math-errno -fPIC -DOMPI_SKIP_MPICXX -DMPICH_SKIP_MPICXX" --FFLAGS="-O2 -ftree-vectorize -march=native -fno-math-errno -fPIC" --with-mpi=1 --with-build-step-np=8 --with-shared-libraries=1 --with-debugging=0 --with-pic=1 --with-x=0 --with-windows-graphics=0 --with-numpy=1 --with-mpi4py=1 --with-fftw=1 --with-fftw-include=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/FFTW/3.3.8-gompi-2018b/include --with-fftw-lib=[/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/FFTW/3.3.8-gompi-2018b/lib/libfftw3_mpi.a,libfftw3.a] --with-scalapack=1 --with-scalapack-include=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/ScaLAPACK/2.0.2-gompi-2018b-OpenBLAS-0.3.1/include --with-scalapack-lib=[/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/ScaLAPACK/2.0.2-gompi-2018b-OpenBLAS-0.3.1/lib/libscalapack.a,libopenblas.a,libgfortran.a] --with-blas-lapack-lib=[/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/OpenBLAS/0.3.1-GCC-7.3.0-2.30/lib/libopenblas.a,libgfortran.a] --with-flex=1 --with-flex-dir=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/flex/2.6.4-GCCcore-7.3.0 --with-bison=1 --with-bison-dir=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/Bison/3.0.5-GCCcore-7.3.0 --with-python=1 --with-python-dir=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/Python/2.7.15-foss-2018b --with-hdf5=1 --with-hdf5-dir=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/HDF5/1.10.2-foss-2018b --with-valgrind=1 --with-valgrind-dir=/rds/bear-apps/devel/eb-sjb-up/EL7/EL7-cascadelake/software/Valgrind/3.14.0-foss-2018b
The important parts of that are: --with-flex=1, --with-bison=1, and --with-python=1. I.e. all the build deps are sent through to PETSc.
That is because the self.cfg.builddependencies()
depfilter is:
[{'full_mod_name': 'CMake/3.12.1-GCCcore-7.3.0', 'short_mod_name': 'CMake/3.12.1-GCCcore-7.3.0', 'name': 'CMake', 'version': '3.12.1', 'versionsuffix': '', 'toolchain': {'name': 'GCCcore', 'version': '7.3.0'}, 'toolchain_inherited': False, 'system': False, 'hidden': False, 'build_only': True, 'external_module': False, 'external_module_metadata': {}}, {'full_mod_name': 'flex/2.6.4-GCCcore-7.3.0', 'short_mod_name': 'flex/2.6.4-GCCcore-7.3.0', 'name': 'flex', 'version': '2.6.4', 'versionsuffix': '', 'toolchain': {'name': 'GCCcore', 'version': '7.3.0'}, 'toolchain_inherited': False, 'system': False, 'hidden': False, 'build_only': True, 'external_module': False, 'external_module_metadata': {}}, {'full_mod_name': 'Bison/3.0.5-GCCcore-7.3.0', 'short_mod_name': 'Bison/3.0.5-GCCcore-7.3.0', 'name': 'Bison', 'version': '3.0.5', 'versionsuffix': '', 'toolchain': {'name': 'GCCcore', 'version': '7.3.0'}, 'toolchain_inherited': False, 'system': False, 'hidden': False, 'build_only': True, 'external_module': False, 'external_module_metadata': {}}, {'full_mod_name': 'Python/2.7.15-foss-2018b', 'short_mod_name': 'Python/2.7.15-foss-2018b', 'name': 'Python', 'version': '2.7.15', 'versionsuffix': '', 'toolchain': {'name': 'foss', 'version': '2018b'}, 'toolchain_inherited': False, 'system': False, 'hidden': False, 'build_only': True, 'external_module': False, 'external_module_metadata': {}}, 'BLACS', 'BLAS', 'CMake', 'FFTW', 'LAPACK', 'numpy', 'mpi4py', 'papi', 'ScaLAPACK', 'SciPy-bundle', 'SuiteSparse']
Member
This was referenced Jan 4, 2021
Member
Author
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
Member
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
Member
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfr. discussion in easybuilders/easybuild-easyconfigs#11947