Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Dec 9, 2020

@lexming lexming added the new label Dec 9, 2020
@lexming lexming added this to the 4.x milestone Dec 9, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 15, 2020
@migueldiascosta
Copy link
Member

@lexming it seems #2280 was not enough, there's a similar code block in test/easyblocks/module.py

@lexming
Copy link
Contributor Author

lexming commented Jan 6, 2021

@migueldiascosta fix for those tests in #2302

@easybuilders easybuilders deleted a comment from boegelbot Jan 6, 2021
@lexming
Copy link
Contributor Author

lexming commented Jan 6, 2021

Successful test report in easybuilders/easybuild-easyconfigs#10965 (comment)

@JackPerdue
Copy link
Contributor

It might be useful to split out the part concerning batch/queue systems (i.e. Slurm/Torque/LSF(?)) and their particulars to its own easyblock for use by others that might want to use it. I don't know what the EB framework uses for when it uses jobs to build things (I've always just built on the login nodes), but it might be able to use it too. Just a thought.

@dithwick
Copy link
Contributor

dithwick commented Jan 7, 2021

Two other quick thoughts (although maybe best for a later update):

  • ALTCPU=ON should only be enabled when TBB is in the dependency chain, maybe it's worth detecting this (although I note the corresponding easyconfig does have this).
  • MKLFFT=ON maybe should be added when MKL is detected.

Copy link

@shahpnmlab shahpnmlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 171, results in a str float comparison which is not valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants