Skip to content

filter out user packages in LAMMPS easyblock if corresponding dependency isn't included + only set -DUSER-INTEL on x86_64 systems - #2254

Merged
boegel merged 7 commits into
easybuilders:developfrom
bear-rsg:lammps-vtk-optional
Feb 19, 2021
Merged

filter out user packages in LAMMPS easyblock if corresponding dependency isn't included + only set -DUSER-INTEL on x86_64 systems#2254
boegel merged 7 commits into
easybuilders:developfrom
bear-rsg:lammps-vtk-optional

Conversation

@edmondac

@edmondac edmondac commented Nov 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@edmondac edmondac changed the title Take out the VTK user_package if we haven't got VTK loaded as a dep WIP: Take out the VTK user_package if we haven't got VTK loaded as a dep Nov 27, 2020
akesandgren
akesandgren previously requested changes Nov 27, 2020
View reviewed changes
Comment thread easybuild/easyblocks/l/lammps.py Outdated
akesandgren
akesandgren reviewed Nov 27, 2020
View reviewed changes
Comment thread easybuild/easyblocks/l/lammps.py
@edmondac edmondac mentioned this pull request Nov 27, 2020
Closed
@edmondac edmondac changed the title WIP: Take out the VTK user_package if we haven't got VTK loaded as a dep Take out the VTK user_package if we haven't got VTK loaded as a dep Nov 27, 2020
@boegel boegel changed the title Take out the VTK user_package if we haven't got VTK loaded as a dep filter out user packages in LAMMPS easyblock if corresponding dependency isn't included + only set -DUSER-INTEL on x86_64 systems Nov 29, 2020
@boegel boegel added this to the 4.4.0 milestone Dec 8, 2020
@boegel

boegel commented Feb 19, 2021

Copy link
Copy Markdown
Member

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS LAMMPS-3Mar2020-foss-2019b-Python-3.7.4-kokkos.eb
  • SUCCESS LAMMPS-3Mar2020-foss-2020a-Python-3.8.2-kokkos.eb
  • SUCCESS LAMMPS-3Mar2020-intel-2019b-Python-3.7.4-kokkos.eb
  • SUCCESS LAMMPS-3Mar2020-intel-2020a-Python-3.8.2-kokkos.eb
  • SUCCESS LAMMPS-7Aug2019-foss-2019b-Python-3.7.4-kokkos.eb
  • SUCCESS LAMMPS-7Aug2019-intel-2019b-Python-3.7.4-kokkos-OCTP.eb
  • SUCCESS LAMMPS-7Aug2019-intel-2019b-Python-3.7.4-kokkos.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/2ea94b9786ef704a580683617ec283be for a full test report.

@boegel
boegel dismissed akesandgren’s stale review February 19, 2021 18:06

suggestions taken into account

boegel
boegel approved these changes Feb 19, 2021
View reviewed changes

@boegel boegel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
boegel merged commit 887f4e2 into easybuilders:develop Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren left review comments
@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix enhancement

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@edmondac @boegel @akesandgren