Update TensorFlow easyblock for TensorFlow 2.4 #2225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some dependencies the EB dependency AND the python package must be present. Example: protobuf
Merged
6 tasks
boegel
changed the title
boegel
approved these changes
Nov 9, 2020
Member
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
lgtm, test reports coming up...
Flamefire
commented
Nov 9, 2020
| system_libs.append(tf_name) | ||
| # If it is in deps_with_python_pkg we already added it | ||
| if tf_name not in deps_with_python_pkg: | ||
| system_libs.append(tf_name) |
Contributor
Author
There was a problem hiding this comment.
FTR: Here a set could be used and the check removed. However this approach might be able to catch mistakes when a tf_name is added multiple times although it shouldn't
Member
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Member
|
Thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TF 2.4 some new dependencies are used and SWIG was finally removed. As in 2.4+ the flatbuffers python package is required I generalized the handling of such split-dependencies (1 EB + 1 Python dependency) so that is handled correctly