-
Notifications
You must be signed in to change notification settings - Fork 310
update TensorFlow easyblock to put Bazel build files in build directory + avoid unnecessary runtime patching #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc8df96 to
ecd4bb7
Compare
Contributor
Author
|
Test: x86
POWER
|
Contributor
Author
|
@boegel All tests finished successfully. The 1.13.1 fails due to easybuilders/easybuild-easyconfigs#11253 So IMO good to go. |
When e.g. /dev/shm is used to speed up builds Bazel will now also use that leading to faster builds
ecd4bb7 to
5348b22
Compare
boegel
requested changes
Sep 16, 2020
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
approved these changes
Sep 24, 2020
Member
|
I've also tested this with a wide range of TensorFlow easyconfigs, no problems encountered whatsoever, so good to go. Thanks a lot for your efforts on this @Flamefire! |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we used /tmp (or better: tempdir as set by EB options) to put bazel build files in. However often users set builddir to some fast storage (e.g. /dev/shm) so using that instead can speed up the build of TensorFlow. This PR solves that and also unifies some settings of various directories used
Additionally it removes some patches: