Skip to content

fix assumption in Bazel easyblock that include-fixed subdirectory is always there in GCC installation #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lexming merged 1 commit into from
Jul 7, 2020
Merged

fix assumption in Bazel easyblock that include-fixed subdirectory is always there in GCC installation #2094

lexming merged 1 commit into from
Jul 7, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jul 7, 2020

(partial fix for #2092)

@boegel boegel added the bug fix label Jul 7, 2020
@boegel boegel added this to the 4.2.2 milestone Jul 7, 2020
@boegel
Copy link
Member Author

boegel commented Jul 7, 2020

confirmed fix for broken Bazel installation:

$ eb Bazel-2.0.0-GCCcore-8.3.0.eb
...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/Bazel/2.0.0/GCCcore-8.3.0):
build failed (first 300 chars): Derived directory /software/GCCcore/8.3.0/lib/gcc/x86_64-pc-linux-gnu/8.3.0/include-fixed does not exist (took 9 sec)

lexming
lexming approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Jul 7, 2020

Positive test with Bazel-2.0.0-GCCcore-8.3.0.eb
https://gist.github.com/lexming/48dcbd9fbd4c724de87851693228ba42

@lexming
Copy link
Contributor

lexming commented Jul 7, 2020

Positive test with Bazel-1.1.0-GCCcore-8.3.0.eb
https://gist.github.com/lexming/ae1812bab3efb0b05bb53e680695e0be

@lexming
Copy link
Contributor

lexming commented Jul 7, 2020

Positive test with Bazel-0.29.1-GCCcore-8.3.0.eb
https://gist.github.com/lexming/08cd9f8e29f10bba33ef1ae4691f740c

@lexming
Copy link
Contributor

lexming commented Jul 7, 2020

Going in, thanks @boegel !

@lexming lexming merged commit d5ccb42 into easybuilders:develop Jul 7, 2020
@boegel boegel deleted the fix_bazel_include_fixed branch July 7, 2020 10:59
boegel added a commit to boegel/easybuild-easyblocks that referenced this pull request Jul 7, 2020
@boegel
add PRs easybuilders#2093 and easybuilders#2094 to EasyBuild v4.2.2 r…
ba746ec 
…elease notes
This was referenced Jul 7, 2020
Closed
Merged
migueldiascosta added a commit to migueldiascosta/easybuild-easyblocks that referenced this pull request Jul 8, 2020
@migueldiascosta
Merge pull request #4 from boegel/eb422
47349b2 
add PRs easybuilders#2093 and easybuilders#2094 to EasyBuild v4.2.2 release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @lexming