Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Apr 27, 2020

This PR improves the sanity checks of impi easyblock by building the minimal MPI test program test.c and adding its execution to the sanity check commands.

I tested it with latest impi-2019.7.217-iccifort-2020.1.217.eb

The tests are currently enabled for all versions as this test program is available in all non-archived releases of impi.

@lexming lexming added this to the next release (4.2.1?) milestone Apr 27, 2020
@lexming
Copy link
Contributor Author

lexming commented Apr 28, 2020

Positive test with last commit is available at https://gist.github.com/lexming/638c1af52b057f56fa90f55b7ee37c05

lexming added 2 commits May 2, 2020 18:32
use get_mpi_cmd_template function in impi easyblock to determine MPI test command to run
@lexming
Copy link
Contributor Author

lexming commented May 2, 2020

SUCCESSFUL test with impi-2019.7.217-iccifort-2020.1.217.eb at: https://gist.github.com/lexming/0b9c92be1146d7c2f9369508a2910515

@lexming
Copy link
Contributor Author

lexming commented May 2, 2020

SUCCESSFUL test with impi-2018.3.222-GCC-7.3.0-2.30.eb at: https://gist.github.com/lexming/d8171b4d9dd89bf6fed6d132f67a4d3f

@boegel
Copy link
Member

boegel commented May 4, 2020

@lexming The oldest impi versions we still have (4.x, 5.x) don't have test/test.c available, so I've added a commit to only build & run the test command for recent versions (>= 2017.x)...

@boegel boegel merged commit 29aa040 into easybuilders:develop May 4, 2020
@lexming lexming deleted the impi-test branch June 2, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants