Skip to content

Conversation

@branfosj
Copy link
Member

This:

  • adds a light theme
  • toggle selection between dark and light themes
  • simplifies the dark theme to just override the changes from slate

[data-md-color-scheme="default"] {
/* EB colours - main logo border colours */
--eb-blue: #72a4b0;
--eb-green: #8ca379;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the blue and green is a bit too light on a white background imho, so let's use slightly darker variants, see branfosj#2

@boegel boegel changed the title Light theme add light theme + support for switching between dark/light theme Mar 15, 2023
@boegel
Copy link
Member

boegel commented Mar 15, 2023

@branfosj Looks like CodeSpell found a couple of (new) problems, let's tackle those in a separate PR?

Error: ./docs/release-notes.md:7711: extermal ==> external, extremal
Error: ./docs/release-notes.md:9147: Pytho ==> Python
Error: ./docs/release-notes.md:12488: Pilon ==> Pylon, Pillion
Error: ./docs/release-notes.md:23614: Oger ==> Ogre
Codespell found one or more problems

@branfosj
Copy link
Member Author

@boegel I've fixed two spelling mistakes in 734c5cd, but I also suggest we skip spell checking the release notes (see #125)

@boegel boegel merged commit 52a24e9 into easybuilders:develop Mar 19, 2023
@branfosj branfosj deleted the light-dark branch March 19, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants