Update Composer Linting Scripts #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a separate `fix-rector` along the lines of `fix-cs` to respect the original author's preferred approach. The aliases just make it easy for other contributors to run all the tools in the correct order without having to look it up.
The default of 128M was causing consistent crashes for me on Github Codespaces. Since Rector uses PhpStan in the background, I also upped it's limit. Though this really shouldn't matter, since Rector can use the existing cache and needs less memory anyway.
Contributor
|
Looks good :) thank you for contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple PR, aimed at contributor QoL. This adds
lintandlint.fixcomposer scripts, allowing contributors to run all lint checks (and fixers) in one command without having to look it up.I've also upped the memory limit of PhpStan being used to 1G (from the 128M default). I needed to manually use these flags for the first cache-less run or I would receive an out-of-memory error.