Fix DATA_COUNT to account for number of destinations [11446] #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
changed the title
MiguelCompany
force-pushed
the
feature/statistics/rtps/data-count-rework
branch
from
0de02a9 to
198e7fc
Compare
MiguelCompany
force-pushed
the
feature/statistics/rtps/data-count-rework
branch
2 times, most recently
from
6671995 to
fbf9faf
Compare
MiguelBarro
suggested changes
May 10, 2021
Contributor
MiguelBarro
left a comment
MiguelBarro
left a comment
There was a problem hiding this comment.
On test RTPSStatisticsTests.statistics_rpts_avoid_empty_resent_callbacks the SAMPLE_DATAS callback is expected:
Fast-DDS/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
Lines 926 to 931 in 8def391
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
feature/statistics/rtps/data-count-rework
branch
from
fbf9faf to
75aebbf
Compare
Member
Author
I have rebased this PR, as this has already been fixed on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1945 and fixes the way DATA_COUNT collect samples, in order to make it more accurate and also improve performance by calling the listener fewer times (once per
send_any_unsent_changes/unsent_change_added_to_historycall)