fix: TUI any types, logger strong types, PLAN.md rewrite#23
Merged
Conversation
TUI type safety (17 any removed): - session/index.tsx: ToolProps generics, state narrowing with discriminated unions, typed tool inputs (WebFetch, CodeSearch, WebSearch) - kv.tsx: get/set use unknown instead of any - local.tsx: typed response shape - dialog.tsx: replace() takes JSX.Element - toast.tsx: error callback typed Logger type safety (util/log.ts): - LogMessage: unknown → string | Error - LogExtra: Record<string, unknown> → Record<string, string | number | boolean | null | Error | object> - 17 caller files updated with error narrowing (instanceof Error ? e : String(e)) PLAN.md rewritten: - Removed completed sections (bug fixes, type safety tiers, upstream sync phases) - Added remaining work items (TUI types, Zod v3→v4, upstream re-sync) - Updated completed features table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anytypes removed across 5 TUI component filesLogMessage = string | Error,LogExtra = Record<string, ...specific types...>, 17 caller files updated with error narrowingTUI Type Fixes
routes/session/index.tsxcontext/kv.tsxcontext/local.tsxui/dialog.tsxui/toast.tsxLogger Type Fixes
LogMessage:unknown->string | ErrorLogExtra:Record<string, unknown>->Record<string, string | number | boolean | null | Error | object>e instanceof Error ? e : String(e)narrowingFinal
anyCount: 20All remaining are documented structural exceptions (event emitters, SDK boundaries, generic patterns).
Test plan
bun run typecheck(tsgo) — 0 errorsbun test— 1448 pass, 0 fail