refactor: eliminate Instance.state() — convert 16 modules#20
Merged
Conversation
…evel state maps Replace all Instance.state() usage with module-level Map<directory, state> plus registerDisposer() for cleanup. Delete State module, Scheduler module (replaced by inline timer in bootstrap), and their tests. Services registered in instances.ts (simple, no circular deps): EnvService, BusService, SessionStatusService, InstructionService Services using registerDisposer (complex import graphs): Config, TuiConfig, Plugin, ToolRegistry, Provider, Agent, Command, Prompt, PTY, LSP, MCP Verification: 0 errors (bun typecheck), 1423 tests pass, 0 Instance.state() remaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instance.state()modules to module-levelMap<directory, state>withregisterDisposer()for lifecycle cleanupStatemodule (src/project/state.ts) and removestate()method fromInstanceSchedulermodule (src/scheduler/index.ts) — replaced by inlinesetIntervalin bootstrapinstances.ts:EnvService,BusService,SessionStatusService,InstructionServiceregisterDisposerdirectly (Config, TuiConfig, Plugin, ToolRegistry, Provider, Agent, Command, Prompt, PTY, LSP, MCP) — can't be ininstances.tsdue to circular import constraintsModules converted (by stage)
Test plan
bun typecheck— 0 errors across all 13 packagesbun test— 1423 tests pass, 0 failuresgrep -rn 'Instance\.state(' packages/opencode/src/— 0 results