Skip to content

Fixing formatting issue in language_model_constants.ts#3156

Merged
wwwillchen merged 1 commit intodyad-sh:mainfrom
azizmejri1:build-error-formatting
Apr 7, 2026
Merged

Fixing formatting issue in language_model_constants.ts#3156
wwwillchen merged 1 commit intodyad-sh:mainfrom
azizmejri1:build-error-formatting

Conversation

@azizmejri1
Copy link
Copy Markdown
Collaborator

@azizmejri1 azizmejri1 commented Apr 7, 2026

This issue is causing build failure in the main branch

@wwwillchen
Copy link
Copy Markdown
Collaborator

@BugBot run

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@dyad-assistant
Copy link
Copy Markdown
Contributor

dyad-assistant bot commented Apr 7, 2026

πŸ” Dyadbot Code Review Summary

Verdict: βœ… YES - Ready to merge

βœ… No issues found by multi-agent review. This PR is a trivial Prettier formatting fix collapsing a wrapped description string in language_model_constants.ts onto a single line, plus a routine package-lock.json version bump (0.41.0 β†’ 0.42.0). No behavioral changes.


Generated by Dyadbot multi-agent code review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 0.42.0 and reformats the description of the MiniMax-M2.7-highspeed model in the language model constants. I have no feedback to provide.

@github-actions github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🎭 Playwright Test Results

❌ Some tests failed

OS Passed Failed Flaky Skipped
🍎 macOS 262 7 7 6

Summary: 262 passed, 7 failed, 7 flaky, 6 skipped

Failed Tests

🍎 macOS

  • context_manage.spec.ts > manage context - default
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • context_manage.spec.ts > manage context - smart context
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • context_manage.spec.ts > manage context - exclude paths
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • context_manage.spec.ts > manage context - exclude paths with smart context
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • custom_apps_folder.spec.ts > new apps are stored in the user's custom folder
    • Error: expect(received).toBe(expected) // Object.is equality
  • github.spec.ts > create and sync to existing repo
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • select_component.spec.ts > select component next.js
    • Error: expect(locator).toBeVisible() failed

πŸ“‹ Re-run Failing Tests (macOS)

Copy and paste to re-run all failing spec files locally:

npm run e2e \
  e2e-tests/context_manage.spec.ts \
  e2e-tests/custom_apps_folder.spec.ts \
  e2e-tests/github.spec.ts \
  e2e-tests/select_component.spec.ts

⚠️ Flaky Tests

🍎 macOS

  • chat_tabs.spec.ts > clicking a tab switches to that chat (passed after 1 retry)
  • chat_tabs.spec.ts > closing a tab removes it and selects adjacent tab (passed after 1 retry)
  • restart.spec.ts > restart app (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)
  • switch_versions.spec.ts > switch versions (isomorphic git) (passed after 1 retry)
  • toggle_screen_sizes.spec.ts > Toggle Screen Size Tests > should persist device mode after rebuild (passed after 1 retry)
  • undo.spec.ts > undo after assistant with no code (passed after 1 retry)

πŸ“Š View full report

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​modelcontextprotocol/​sdk@​1.18.1997010099100
Added@​storybook/​react-vite@​8.6.159910066100100
Added@​types/​glob@​8.1.01001007081100
Added@​types/​uuid@​10.0.01001007081100
Updated@​typescript-eslint/​parser@​8.30.1 ⏡ 5.62.0100 +11007098100
Added@​electron-forge/​cli@​7.11.1991007095100
Added@​electron-forge/​plugin-auto-unpack-natives@​7.11.11001007196100
Added@​typescript/​native-preview@​7.0.0-dev.20260107.110010071100100
Added@​electron-forge/​maker-zip@​7.11.11001007196100
Added@​types/​better-sqlite3@​7.6.131001007180100
Added@​tailwindcss/​vite@​4.1.131001007298100
Added@​ai-sdk/​openai@​3.0.36721008898100
Added@​types/​node-fetch@​2.6.131001007381100
Added@​flakiness/​playwright@​1.0.0731009993100
Added@​storybook/​react@​8.6.159310073100100
Added@​electron-forge/​maker-squirrel@​7.11.11001007496100
Added@​ai-sdk/​mcp@​1.0.18991007498100
Added@​ai-sdk/​azure@​3.0.26741008398100
Added@​electron-forge/​maker-rpm@​7.11.11001007496100
Updated@​types/​react-dom@​19.2.3 ⏡ 19.1.9100 +11007587 +1100
Added@​electron-forge/​maker-deb@​7.11.11001007596100
Added@​types/​fs-extra@​11.0.41001007580100
Added@​ai-sdk/​provider-utils@​4.0.13931007698100
Added@​vscode/​ripgrep@​1.17.0911007791100
Added@​electron-forge/​publisher-github@​7.11.1971007796100
Added@​ai-sdk/​anthropic@​3.0.35781008798100
Added@​storybook/​blocks@​8.6.149210078100100
Added@​electron-forge/​plugin-fuses@​7.11.11001007896100
Updated@​typescript-eslint/​eslint-plugin@​8.30.1 ⏡ 5.62.095 -410079 -198100
Addedbabel-plugin-react-compiler@​1.0.01001007997100
Added@​ai-sdk/​google@​3.0.20791008798100
Added@​types/​kill-port@​2.0.3971008379100
Updated@​types/​react@​19.2.8 ⏡ 19.1.12100 +110080 +192 -2100
See 28 more rows in the dashboard

View full report

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "β–Ά" to expand/collapse)
Warn High
HTTP dependency: npm @electron/rebuild depends on https://github.com/electron/node-gyp#06b29aafb7708acef8b3669835c8a7857ebc92d2

Dependency: @electron/node-gyp@https://github.com/electron/node-gyp#06b29aafb7708acef8b3669835c8a7857ebc92d2

Location: Package overview

From: package-lock.json β†’ npm/@electron-forge/maker-rpm@7.11.1 β†’ npm/@electron-forge/plugin-auto-unpack-natives@7.11.1 β†’ npm/@electron-forge/maker-deb@7.11.1 β†’ npm/@electron-forge/publisher-github@7.11.1 β†’ npm/@electron-forge/plugin-vite@7.11.1 β†’ npm/@electron-forge/plugin-fuses@7.11.1 β†’ npm/@electron-forge/maker-squirrel@7.11.1 β†’ npm/@electron-forge/cli@7.11.1 β†’ npm/@electron-forge/maker-zip@7.11.1 β†’ npm/@electron/rebuild@3.7.2

β„Ή Read more on: This package | This alert | What are http dependencies?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Publish the HTTP URL dependency to a public or private package repository and consume it from there.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@electron/rebuild@3.7.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@wwwillchen
Copy link
Copy Markdown
Collaborator

thanks!

@wwwillchen wwwillchen merged commit 0e436bc into dyad-sh:main Apr 7, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human:review-issue ai agent flagged an issue that requires human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants