feat: block unsafe npm package installs by keppo-bot[bot] · Pull Request #3152 · dyad-sh/dyad

keppo-bot · 2026-04-07T00:47:04Z

Summary

add a default-on Experiments setting to block unsafe npm packages with Socket Firewall
wrap shared add-dependency installs in sfw when available and bootstrap sfw via npm install -g sfw when it is missing
surface firewall bootstrap warnings through build-mode approvals and local-agent add_dependency flows, with tests for the new setting and install path

Test plan

npm run fmt && npm run lint:fix && npm run ts
npm test

🤖 Generated with Claude Code

cubic-dev-ai

No issues found across 22 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

- preserve socket firewall warnings across error paths - fall back to direct package installs when sfw has runtime failures - restore Windows shell execution for npm-style commands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 490a6e7477

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T04:23:26Z

src/ipc/processors/executeAddDependency.ts

+    warningMessages.push(SOCKET_FIREWALL_FALLBACK_WARNING_MESSAGE);
+    ({ succeeded, installResults, lastError } = await runAddDependencyCommands(
+      buildAddDependencyCommands(packages, false),


Delay fallback warning until plain install actually succeeds

This branch pushes SOCKET_FIREWALL_FALLBACK_WARNING_MESSAGE before the unwrapped pnpm/npm retry runs, so when the fallback commands also fail the user still gets a warning that says Dyad installed the packages without firewall checks. In that failure scenario the warning is factually wrong and can send users debugging the wrong issue; only emit this warning after the fallback succeeds (or use a different message for fallback failure).

Useful? React with 👍 / 👎.

src/ipc/processors/executeAddDependency.ts

  const updatedContent = message.content.replace(
    new RegExp(
-      `<dyad-add-dependency packages="${packages.join(" ")}">[^<]*</dyad-add-dependency>`,
+      `<dyad-add-dependency packages="(?:${buildPackagesAttrPattern(packages)})">[\\s\\S]*?</dyad-add-dependency>`,


chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89796cad72

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T05:04:27Z

src/ipc/processors/executeAddDependency.ts

+  const packageManager = await detectPreferredPackageManager();
+  let { succeeded, installResults, lastError } = await runAddDependencyCommand(
+    buildAddDependencyCommand(packages, packageManager, useSocketFirewall),
+    appPath,
  );


Retry npm when pnpm add fails

This change now selects a single package manager based only on whether pnpm exists and executes one install path, so when pnpm is present but pnpm add exits non-zero (for example, repo-specific pnpm failures), the function throws instead of retrying with npm. The previous behavior explicitly attempted npm after a pnpm failure, so this is a regression that can make dependency installs fail on environments that happen to have pnpm installed.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10df01b0cd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T17:05:12Z

src/main.ts

  // Cleanup old media files to reclaim disk space
  cleanupOldMediaFiles();

+  await applyRemoteSettingsDefaultsIfNeeded();


Avoid blocking startup on remote settings fetch

onReady() now awaits applyRemoteSettingsDefaultsIfNeeded() before createWindow(), so app launch is gated on the remote desktop-config request. Because that fetch uses a 5,000 ms timeout, users on slow/offline networks can see a multi-second cold-start delay before any window appears; running this fetch asynchronously (or after first window creation) would avoid this startup regression while still applying defaults.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30c0c7296e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T17:40:00Z

src/ipc/processors/executeAddDependency.ts

-}) {
-  const packageStr = packages.join(" ");
+}): Promise<ExecuteAddDependencyResult> {
+  const settings = readEffectiveSettings();


Read effective settings asynchronously for dependency installs

executeAddDependency uses the synchronous readEffectiveSettings() path, which only consults getCachedRemoteDesktopConfig() and then defaults blockUnsafeNpmPackages to true when the cache is missing/expired. With an unset local value and a remote default of false, this makes install behavior flip back to firewall-on after cache expiry (or before any async refresh), so package installs can unexpectedly start failing in the same session. Please use the async effective-settings read here (or otherwise persist/refresh the last remote default) so remote defaults stay consistent.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-07T17:40:00Z

src/ipc/shared/remote_desktop_config.ts

+        remoteDesktopConfigCache = {
+          config: null,
+          expiresAt: Date.now() + FAILURE_CACHE_TTL_MS,


Preserve last known remote config on fetch failures

On fetch errors this branch overwrites the cache with config: null, which discards any previously successful remote defaults. For users without a local override, a transient network failure then changes effective behavior (via fallback to true) until the next successful fetch, causing settings-driven install policy to flap. Keeping the last good config while applying a shorter retry TTL would avoid these unintended flips.

Useful? React with 👍 / 👎.

github-actions · 2026-04-07T18:23:54Z

🎭 Playwright Test Results

❌ Some tests failed

OS	Passed	Failed	Flaky	Skipped
🍎 macOS	406	2	4	131
🪟 Windows	406	11	4	131

Summary: 812 passed, 13 failed, 8 flaky, 262 skipped

Failed Tests

🍎 macOS

queued_message.spec.ts > editing queued message restores attachments and selected components
- Error: expect(locator).toBeVisible() failed
queued_message.spec.ts > canceling queued message edit clears restored components
- Error: expect(locator).toBeVisible() failed

🪟 Windows

Show all 11 failures

context_manage.spec.ts > manage context - default
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
context_manage.spec.ts > manage context - smart context
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
context_manage.spec.ts > manage context - smart context - auto-includes only
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
context_manage.spec.ts > manage context - exclude paths
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
context_manage.spec.ts > manage context - exclude paths with smart context
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
github.spec.ts > should connect to GitHub using device flow
- Error: expect(locator).toBeVisible() failed
github.spec.ts > create and sync to new repo
- Error: expect(locator).toHaveClass(expected) failed
github.spec.ts > create and sync to new repo - custom branch
- TimeoutError: locator.click: Timeout 30000ms exceeded.
github.spec.ts > create and sync to existing repo
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
github.spec.ts > create and sync to existing repo - custom branch
- Error: expect(locator).toMatchAriaSnapshot(expected) failed
github.spec.ts > github clear integration settings
- Error: expect(locator).toBeVisible() failed

📋 Re-run Failing Tests (macOS)

Copy and paste to re-run all failing spec files locally:

npm run e2e \
  e2e-tests/queued_message.spec.ts

⚠️ Flaky Tests

🍎 macOS

chat_input.spec.ts > send button disabled during pending proposal - reject (passed after 1 retry)
context_limit_banner.spec.ts > context limit banner shows 'running out' when near context limit (passed after 1 retry)
debugging_logs.spec.ts > clear logs button clears all logs (passed after 1 retry)
setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)

🪟 Windows

edit_code.spec.ts > edit code (passed after 2 retries)
git_collaboration.spec.ts > Git Collaboration > should create, switch, rename, merge, and delete branches (passed after 1 retry)
setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)
setup_flow.spec.ts > Setup Flow > node.js install flow (passed after 2 retries)

📊 View full report

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 190ce65df6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T18:33:56Z

src/ipc/handlers/settings_handlers.ts

  createTypedHandler(settingsContracts.setUserSettings, async (_, settings) => {
    writeSettings(settings);
-    return readSettings();
+    return readEffectiveSettings();


Avoid awaiting remote config in settings write handler

setUserSettings now returns readEffectiveSettings(), which performs a remote desktop-config fetch (with a 5s timeout on cache miss) before resolving. In offline/slow-network scenarios this makes every settings toggle wait on that network call, so controlled switches can appear stuck and setting updates feel unresponsive even though local persistence is synchronous. Returning locally written settings (or using only cached remote defaults) would prevent this user-visible latency regression.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75bbf0c7bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T20:02:02Z

src/main/settings.ts

+export async function readEffectiveSettings(): Promise<UserSettings> {
+  const settings = readSettings();
+  const remoteConfig = await getRemoteDesktopConfig();
+  return resolveEffectiveSettings(settings, remoteConfig);


Short-circuit remote fetch when local setting is explicit

readEffectiveSettings() always awaits getRemoteDesktopConfig() even when settings.blockUnsafeNpmPackages is already explicitly set, so operations that call it (including dependency installs and settings reads/writes) are unnecessarily coupled to a network request with a 5s timeout. In offline/slow-network scenarios this adds avoidable latency despite the local value already taking precedence; returning early when the local boolean is present avoids these stalls without changing behavior.

Useful? React with 👍 / 👎.

feat: block unsafe npm package installs

7bcd552

keppo-bot bot requested a review from a team April 7, 2026 00:47

docs: record session learnings

0a7d98e

This comment was marked as resolved.

Sign in to view

cubic-dev-ai bot reviewed Apr 7, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

fix: surface socket firewall verdicts in dependency errors

db7f402

This comment was marked as resolved.

Sign in to view

test: cover blocked socket firewall packages

a6c2b48

keppo-bot bot removed the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

docs: record session learnings

737f660

This comment was marked as resolved.

Sign in to view

github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

This comment was marked as resolved.

Sign in to view

wwwillchen and others added 2 commits April 6, 2026 21:01

fmt

9a76230

Address PR review comments

490a6e7

- preserve socket firewall warnings across error paths - fall back to direct package installs when sfw has runtime failures - restore Windows shell execution for npm-style commands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

fix: short-circuit dependency installs

bc6909d

keppo-bot bot removed the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

docs: record session learnings

89796ca

github-advanced-security bot found potential problems Apr 7, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

Add remote default for socket firewall

a01cfbc

keppo-bot bot removed the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

docs: record session learnings

10df01b

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

Refactor remote socket firewall defaults

30c0c72

github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 7, 2026

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

Make effective settings reads fully async

190ce65

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

wwwillchen added 2 commits April 7, 2026 12:54

Fail closed on socket firewall errors

b9c19bd

Format effective settings test

75bbf0c

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

wwwillchen merged commit 2ff6fb1 into main Apr 7, 2026
16 of 23 checks passed

This was referenced Apr 7, 2026

Fix keppo-bot allowlist #3159

Closed

PR Summary: Chat Mode Persistence & Code Review Fixes #3142

Draft

Conversation

keppo-bot bot commented Apr 7, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

This comment was marked as resolved.

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2026

🎭 Playwright Test Results

❌ Some tests failed

Failed Tests

🍎 macOS

🪟 Windows

📋 Re-run Failing Tests (macOS)

⚠️ Flaky Tests

🍎 macOS

🪟 Windows

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

keppo-bot bot commented Apr 7, 2026 •

edited by devin-ai-integration bot

Loading