Skip to content

refactor: remove NewBadge from ChatModeSelector#3113

Merged
wwwillchen merged 1 commit intomainfrom
agent--1775072882111-1775072693
Apr 2, 2026
Merged

refactor: remove NewBadge from ChatModeSelector#3113
wwwillchen merged 1 commit intomainfrom
agent--1775072882111-1775072693

Conversation

@keppo-bot
Copy link
Copy Markdown
Contributor

@keppo-bot keppo-bot bot commented Apr 1, 2026

Summary

  • Removed the unused NewBadge component from ChatModeSelector.tsx
  • Removed "New" badge displays from Agent v2 and Plan mode options, as these features are no longer new

Test plan

  • Verify the chat mode selector dropdown still renders correctly without the "New" badges
  • Confirm Agent v2 and Plan mode options are still selectable and functional

πŸ€– Generated with Claude Code


Open with Devin

The "New" badge on Agent v2 and Plan modes is no longer needed as these
features are no longer new. Remove the unused NewBadge component and its
usages.

Co-Authored-By: Claude <noreply@anthropic.com>
@keppo-bot keppo-bot bot requested a review from a team April 1, 2026 19:47
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@wwwillchen wwwillchen closed this Apr 1, 2026
@wwwillchen wwwillchen reopened this Apr 1, 2026
@github-actions github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🎭 Playwright Test Results

❌ Some tests failed

OS Passed Failed Flaky Skipped
🍎 macOS 406 3 4 129
πŸͺŸ Windows 409 5 7 129

Summary: 815 passed, 8 failed, 11 flaky, 258 skipped

Failed Tests

🍎 macOS

  • queued_message.spec.ts > editing queued message restores attachments and selected components
    • Error: expect(locator).toBeVisible() failed
  • queued_message.spec.ts > canceling queued message edit clears restored components
    • Error: expect(locator).toBeVisible() failed
  • setup_flow.spec.ts > Setup Flow > node.js install flow
    • TimeoutError: locator.dispatchEvent: Timeout 30000ms exceeded.

πŸͺŸ Windows

  • concurrent_chat.spec.ts > concurrent chat
    • Error: expect(locator).toBeVisible() failed
  • github.spec.ts > create and sync to new repo
    • TimeoutError: page.waitForSelector: Timeout 5000ms exceeded.
  • github.spec.ts > create repo with spaces in name - should normalize to hyphens
    • TimeoutError: page.waitForSelector: Timeout 5000ms exceeded.
  • github.spec.ts > create and sync to existing repo
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • github.spec.ts > create and sync to existing repo - custom branch
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed

πŸ“‹ Re-run Failing Tests (macOS)

Copy and paste to re-run all failing spec files locally:

npm run e2e \
  e2e-tests/queued_message.spec.ts \
  e2e-tests/setup_flow.spec.ts

⚠️ Flaky Tests

🍎 macOS

  • chat_input.spec.ts > send button disabled during pending proposal (passed after 1 retry)
  • concurrent_chat.spec.ts > concurrent chat (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)
  • smart_context_options.spec.ts > switching smart context mode saves the right setting (passed after 1 retry)

πŸͺŸ Windows

  • chat_input.spec.ts > send button disabled during pending proposal (passed after 1 retry)
  • chat_input.spec.ts > send button disabled during pending proposal - reject (passed after 2 retries)
  • chat_mode.spec.ts > chat mode selector - ask mode (passed after 2 retries)
  • chat_tabs.spec.ts > right-click context menu: Close tabs to the right (passed after 1 retry)
  • github.spec.ts > should connect to GitHub using device flow (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > node.js install flow (passed after 1 retry)

πŸ“Š View full report

@wwwillchen wwwillchen merged commit 7b8fcd8 into main Apr 2, 2026
28 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human:review-issue ai agent flagged an issue that requires human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant