Skip to content

chore: remove Anthropic context-1m beta header#3103

Merged
wwwillchen merged 1 commit intodyad-sh:mainfrom
wwwillchen-bot:chore/remove-anthropic-context-1m-beta-header
Mar 30, 2026
Merged

chore: remove Anthropic context-1m beta header#3103
wwwillchen merged 1 commit intodyad-sh:mainfrom
wwwillchen-bot:chore/remove-anthropic-context-1m-beta-header

Conversation

@wwwillchen
Copy link
Copy Markdown
Collaborator

@wwwillchen wwwillchen commented Mar 30, 2026

Summary

  • Stop sending anthropic-beta: context-1m-2025-08-07 on Anthropic API requests.
  • getAiHeaders remains for future provider-specific headers but currently returns undefined.

Test plan

  • npm run fmt && npm run lint:fix && npm run ts
  • npm test (952 tests)

#skip-bugbot

πŸ€– Generated with Claude Code

Made with Cursor


Open with Devin

Stop sending anthropic-beta: context-1m-2025-08-07; getAiHeaders is a no-op for now.

Made-with: Cursor
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Anthropic anthropic-beta: context-1m-2025-08-07 header from outgoing Anthropic API requests, leaving the getAiHeaders hook in place for future provider-specific headers.

Changes:

  • Removed the Anthropic-specific anthropic-beta request header.
  • Updated getAiHeaders docs and implementation to currently return undefined (placeholder for future headers).

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dyad-assistant
Copy link
Copy Markdown
Contributor

πŸ” Dyadbot Code Review Summary

Verdict: βœ… YES - Ready to merge

Reviewed by 3 independent agents: Correctness Expert, Code Health Expert, UX Wizard.

Issues Summary

No HIGH or MEDIUM issues found.

🟒 Low Priority Notes (1 item)
  • Consider removing getAiHeaders and GetAiHeadersParams entirely - src/ipc/utils/provider_options.ts β€” The function now unconditionally returns undefined and the parameter is prefixed with _ (unused). YAGNI suggests removing it. However, since it's already wired into 3 call sites, keeping the no-op stub avoids re-threading when a new beta header is needed β€” a reasonable trade-off.
🚫 Dropped False Positives (0 items)

None.


Generated by Dyadbot multi-agent code review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the getAiHeaders function in src/ipc/utils/provider_options.ts to remove the Anthropic-specific beta header logic, effectively turning it into a placeholder that returns undefined. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@github-actions github-actions bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Mar 30, 2026
@wwwillchen wwwillchen merged commit 7717509 into dyad-sh:main Mar 30, 2026
13 of 15 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

❌ Some tests failed

OS Passed Failed Flaky Skipped
🍎 macOS 403 3 4 128
πŸͺŸ Windows 404 5 5 128

Summary: 807 passed, 8 failed, 9 flaky, 256 skipped

Failed Tests

🍎 macOS

  • queued_message.spec.ts > editing queued message restores attachments and selected components
    • Error: expect(locator).toBeVisible() failed
  • queued_message.spec.ts > canceling queued message edit clears restored components
    • Error: expect(locator).toBeVisible() failed
  • visual_editing.spec.ts > swap image via URL
    • TimeoutError: locator.click: Timeout 30000ms exceeded.

πŸͺŸ Windows

  • concurrent_chat.spec.ts > concurrent chat
    • Error: expect(locator).toBeVisible() failed
  • github.spec.ts > create and sync to new repo
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • github.spec.ts > create and sync to existing repo
    • Error: expect(locator).toMatchAriaSnapshot(expected) failed
  • github.spec.ts > github clear integration settings
    • Error: expect(locator).toBeVisible() failed
  • setup_flow.spec.ts > Setup Flow > node.js install flow
    • TimeoutError: locator.dispatchEvent: Timeout 30000ms exceeded.

πŸ“‹ Re-run Failing Tests (macOS)

Copy and paste to re-run all failing spec files locally:

npm run e2e \
  e2e-tests/queued_message.spec.ts \
  e2e-tests/visual_editing.spec.ts

⚠️ Flaky Tests

🍎 macOS

  • chat_input.spec.ts > send button disabled during pending proposal (passed after 1 retry)
  • git_collaboration.spec.ts > Git Collaboration > should create, switch, rename, merge, and delete branches (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > node.js install flow (passed after 2 retries)

πŸͺŸ Windows

  • chat_input.spec.ts > send button disabled during pending proposal (passed after 1 retry)
  • chat_input.spec.ts > send button disabled during pending proposal - reject (passed after 1 retry)
  • edit_code.spec.ts > edit code edits the right file (passed after 1 retry)
  • github.spec.ts > create and sync to existing repo - custom branch (passed after 1 retry)
  • setup_flow.spec.ts > Setup Flow > setup banner shows correct state when node.js is installed (passed after 1 retry)

πŸ“Š View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human:review-issue ai agent flagged an issue that requires human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants