feat: add cc:request label step to pr-push skill#2773
feat: add cc:request label step to pr-push skill#2773wwwillchen merged 1 commit intodyad-sh:mainfrom
Conversation
Add step 8 to the pr-push skill that automatically adds the cc:request label for non-trivial PRs to trigger code review. This prevents issues like lint failures from slipping through when the agent doesn't fully execute lint checks. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary of ChangesHello @wwwillchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@BugBot run |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
github-actions
bot
added
the
needs-human:review-issue
Greptile SummaryThis PR adds a new step 8 to the
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Step 7: Create/Update PR] --> B[Step 8: Evaluate PR triviality]
B --> C{Is PR trivial?}
C -->|Yes: docs-only, snapshot updates, single-line typo| D[Skip label]
C -->|No: source code, test logic, config, 3+ files| E["gh pr edit --add-label cc:request"]
D --> F[Step 9: Remove review-issue label]
E --> F
F --> G[Step 10: Remember learnings]
G --> H[Step 11: Summarize results]
E -.-> I[pr-review-responder.yml triggers]
I -.-> J[Automated code review loop]
Last reviewed commit: 592ad87 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 592ad871e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| If the PR is non-trivial: | ||
|
|
||
| ``` | ||
| gh pr edit --add-label "cc:request" |
There was a problem hiding this comment.
Adding cc:request here can leave PRs stuck in an unprocessed state because the responder workflow only reacts to a labeling event for cc:request:now (.github/workflows/pr-review-responder.yml lines 7-24), while cc:request is only picked up on a later CI workflow_run; if CI has already completed when this step runs (for example, rerunning pr-push on an existing PR with no new push), no responder run is triggered and the status labeler also skips these PRs due to cc:request* (.github/workflows/pr-status-labeler.yml lines 56-64).
Useful? React with 👍 / 👎.
🔍 Dyadbot Code Review SummaryVerdict: 🤔 NOT SURE - Potential issues Reviewed by 3 independent agents: Correctness Expert, Code Health Expert, UX Wizard. Issues Summary
🟢 Low Priority Notes (1 item)
🚫 Dropped False Positives (2 items)
Generated by Dyadbot multi-agent code review |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 5/5
- Only a minor documentation formatting issue in
.claude/skills/pr-push/SKILL.mdwhere a paragraph lost indentation in step 10; no functional impact - Low severity and limited scope make this safe to merge with minimal risk
- Pay close attention to
.claude/skills/pr-push/SKILL.md- restore indentation to keep the paragraph within step 10
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/skills/pr-push/SKILL.md">
<violation number="1" location=".claude/skills/pr-push/SKILL.md:194">
P2: Restore the indentation for this paragraph and the subsequent block so they remain part of the numbered list step 10.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| 9. **Remember learnings (after initial push):** | ||
| 10. **Remember learnings (after initial push):** | ||
|
|
||
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. |
There was a problem hiding this comment.
P2: Restore the indentation for this paragraph and the subsequent block so they remain part of the numbered list step 10.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .claude/skills/pr-push/SKILL.md, line 194:
<comment>Restore the indentation for this paragraph and the subsequent block so they remain part of the numbered list step 10.</comment>
<file context>
@@ -160,32 +160,54 @@ Commit any uncommitted changes, run lint checks, fix any issues, and push the cu
-9. **Remember learnings (after initial push):**
+10. **Remember learnings (after initial push):**
+
+Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files.
- Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files.
</file context>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| A PR is **trivial** (skip the label) if it ONLY contains: | ||
| - Documentation-only changes (`.md` files, comments) | ||
| - Snapshot/baseline updates with no test logic changes | ||
| - Single-line typo or formatting fixes | ||
|
|
||
| All other PRs are **non-trivial** (add the label), including: | ||
| - Any changes to source code (`.ts`, `.tsx`, `.js`, etc.) | ||
| - Changes to test logic (not just snapshot baselines) | ||
| - Configuration changes (`.yml`, `.json`, etc.) | ||
| - Any PR touching 3+ files |
There was a problem hiding this comment.
🟡 MEDIUM | logic
Contradictory trivial/non-trivial criteria for 3+ doc files
The trivial criteria say a PR is trivial if it "ONLY contains documentation-only changes (.md files, comments)", but the non-trivial criteria say "Any PR touching 3+ files" is non-trivial. A PR that modifies 3 or more .md files satisfies both rules simultaneously, with no tie-breaking precedence defined.
This ambiguity could cause inconsistent agent behavior across runs.
💡 Suggestion: Clarify precedence, e.g.: "If all changes match the trivial criteria, the PR is trivial regardless of file count." Or remove the 3+ files heuristic since the file-type rules already cover the intent.
|
|
||
| If the PR is non-trivial: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
🟡 MEDIUM | error-handling
No error suppression for label-add command
This command has no error guard, but step 9's analogous label-removal uses 2>/dev/null || true. If the cc:request label doesn't exist in the repository (e.g., on a fork), this command will fail and block subsequent steps (learnings recording, summary).
💡 Suggestion:
| ``` | |
| gh pr edit --add-label "cc:request" 2>/dev/null || true |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully adds a new step to the pr-push skill to automatically label non-trivial PRs with cc:request, which helps ensure appropriate code review coverage. My feedback focuses on adhering to the repository's Git workflow rules regarding the use of the GitHub REST API for labeling (due to known GraphQL issues) and restoring the indentation in step 10 to maintain markdown consistency and readability.
| If the PR is non-trivial: | ||
|
|
||
| ``` | ||
| gh pr edit --add-label "cc:request" |
There was a problem hiding this comment.
According to rules/git-workflow.md, gh pr edit --add-label is known to fail in this repository due to GraphQL deprecation issues. The REST API should be used instead to ensure the label is applied correctly.
| gh pr edit --add-label "cc:request" | |
| gh api repos/dyad-sh/dyad/issues/$(gh pr view --json number -q .number)/labels -f "labels[]=cc:request" |
References
- The repository rules specify that
gh pr edit --add-labelfails due to GraphQL deprecation and the REST API should be used instead.
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. | ||
|
|
||
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. | ||
| If any files were modified by the skill (check with `git status`): | ||
|
|
||
| If any files were modified by the skill (check with `git status`): | ||
| - Stage the modified files: `git add AGENTS.md rules/` | ||
| - Create a new commit for the learnings: | ||
| ``` | ||
| git commit -m "docs: record session learnings" | ||
| ``` | ||
| - Push the learnings commit: | ||
| ``` | ||
| git push | ||
| ``` | ||
| - Stage the modified files: `git add AGENTS.md rules/` | ||
| - Create a new commit for the learnings: | ||
| ``` | ||
| git commit -m "docs: record session learnings" | ||
| ``` | ||
| - Push the learnings commit: | ||
| ``` | ||
| git push | ||
| ``` | ||
|
|
||
| **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. | ||
| **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. |
There was a problem hiding this comment.
The indentation for the content of step 10 was removed in this PR. Restoring the 3-space indentation is necessary to maintain the markdown list structure and consistency with the rest of the document.
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. | |
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. | |
| If any files were modified by the skill (check with `git status`): | |
| If any files were modified by the skill (check with `git status`): | |
| - Stage the modified files: `git add AGENTS.md rules/` | |
| - Create a new commit for the learnings: | |
| ``` | |
| git commit -m "docs: record session learnings" | |
| ``` | |
| - Push the learnings commit: | |
| ``` | |
| git push | |
| ``` | |
| - Stage the modified files: `git add AGENTS.md rules/` | |
| - Create a new commit for the learnings: | |
| ``` | |
| git commit -m "docs: record session learnings" | |
| ``` | |
| - Push the learnings commit: | |
| ``` | |
| git push | |
| ``` | |
| **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. | |
| **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. | |
| Run the `/remember-learnings` skill to capture any errors, snags, or insights from this session into `AGENTS.md` or `rules/` files. | |
| If any files were modified by the skill (check with `git status`): | |
| - Stage the modified files: `git add AGENTS.md rules/` | |
| - Create a new commit for the learnings: | |
| ``` | |
| git commit -m "docs: record session learnings" | |
| ``` | |
| - Push the learnings commit: | |
| ``` | |
| git push | |
| ``` | |
| **IMPORTANT:** Do NOT amend the previous commit. Create a separate commit for learnings so the main work is already pushed before this step. |
1 participant
Summary
pr-pushskill that automatically adds thecc:requestlabel for non-trivial PRs to trigger code reviewTest plan
pr-pushskill SKILL.md has the new step 8 with clear trivial/non-trivial criteriapr-pushon a non-trivial PR and confirmcc:requestlabel is added🤖 Generated with Claude Code