Skip to content

devops: simplify upload to flakiness.io#2735

Merged
wwwillchen merged 1 commit intodyad-sh:mainfrom
aslushnikov:simplify-upload-to-flakiness
Feb 16, 2026
Merged

devops: simplify upload to flakiness.io#2735
wwwillchen merged 1 commit intodyad-sh:mainfrom
aslushnikov:simplify-upload-to-flakiness

Conversation

@aslushnikov
Copy link
Copy Markdown
Contributor

@aslushnikov aslushnikov commented Feb 15, 2026

@aslushnikov aslushnikov requested a review from a team February 15, 2026 08:50
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 15, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aslushnikov
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 15, 2026

Greptile Summary

Replaces complex Node.js script (50 lines) with a simple find + npx flakiness upload command. The original implementation manually installed @flakiness/sdk, iterated through directories, handled attachments, and uploaded reports individually. The new approach delegates all this complexity to the flakiness CLI tool.

Confidence Score: 5/5

  • Safe to merge - straightforward simplification of CI workflow
  • This is a clean refactoring that reduces complexity without changing functionality. The flakiness CLI tool handles all the logic that was previously implemented manually. No security concerns, no breaking changes, and easier to maintain.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/flakiness-upload.yml Simplified flakiness report upload from 50 lines of custom Node.js logic to a single find command with npx

Last reviewed commit: 8667f29

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8667f29c93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

run: |
# Install the flakiness SDK
npm install @flakiness/sdk
find . -name report.json -exec npx -y flakiness upload {} +
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Upload reports individually to avoid all-or-nothing failure

This find ... -exec ... {} + form batches all report.json paths into a single flakiness upload process, so in sharded CI runs (.github/workflows/ci.yml uses shard/shardTotal) one malformed report or transient upload error can make the step fail before the remaining shard reports are recorded. The previous flow handled each shard separately, which preserved partial uploads and avoided losing the entire run’s flakiness data when only one shard artifact is bad.

Useful? React with 👍 / 👎.

@wwwillchen
Copy link
Copy Markdown
Collaborator

thanks!

@wwwillchen wwwillchen merged commit 05d5a50 into dyad-sh:main Feb 16, 2026
4 of 5 checks passed
github-actions bot added a commit that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants