UI improvement: make edit and delete buttons visible for custom AI provider#1535
Merged
wwwillchen merged 2 commits intoOct 14, 2025
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
wwwillchen
requested changes
Oct 14, 2025
wwwillchen
left a comment
wwwillchen
left a comment
Collaborator
There was a problem hiding this comment.
Overall, definitely an improvement UX-wise.
Two comments:
- Can you add tooltips to the edit and delete button? This makes it more obvious what they do before having to click on it.
- Can you look at why the e2e tests are failing? looks like quite a lot are failing so not sure if this changed the test hooks or something
Contributor
Author
|
Thanks @wwwillchen, I have updated the PR |
DisciplesofLove
pushed a commit
to DisciplesofLove/JoyCreate
that referenced
this pull request
Apr 28, 2026
…ovider (dyad-sh#1535) - Move edit and delete actions from hidden popover to visible buttons - Restructure card layout: status badge and action buttons at top, title below <img width="1029" height="414" alt="image" src="https://github.com/user-attachments/assets/60497f87-254e-4f4d-9f8c-ea73b8f2526e" /> closes dyad-sh#1358 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Made edit and delete always visible on custom provider cards and restructured the card layout for clearer actions and status. Improves discoverability and aligns with dyad-sh#1358. - **Refactors** - Replaced popover menu with visible Edit and Delete icon buttons (data-testid: edit-custom-provider, delete-custom-provider). - Moved status badge and actions to the top; title now sits below; badges don’t wrap. - Updated e2e tests to use new buttons and adjusted selectors for the updated heading. <!-- End of auto-generated description by cubic. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1358
Summary by cubic
Made edit and delete always visible on custom provider cards and restructured the card layout for clearer actions and status. Improves discoverability and aligns with #1358.