Chore: Update `eslint` as new version has breaking changes. 💔 ⌛

[nelsonic]

Sadly, eslint has introduced breaking changes a while ago ...
And there have been many PRs from @dependabot attempting to update it that all fail:
https://github.com/dwyl/hapi-auth-jwt2/pulls?q=is%3Apr+eslint

Todo

• First check if there is a clear upgrade path for eslint without wasting too much time ... T25m ⏳
• Remove eslint from the project if upgrade is too tedious ... ✂
• Remove the eslint pre-commit hook
• Update everything! ⏫

hapi-auth-jwt2/package.json

Lines 108 to 109 in c62441e

	"pre-commit": [
	"lint",

[nelsonic]

Checked out the dependabot/npm_and_yarn/eslint-9.19.0 branch, ran npm install and:

npm run lint

> hapi-auth-jwt2@10.7.0 lint
> eslint lib


Oops! Something went wrong! :(

ESLint: 9.19.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

[nelsonic]

Reading: https://stackoverflow.com/questions/78552903/nodejs-eslint-error-could-not-find-config-file

[nelsonic]

Reading: https://eslint.org/docs/latest/use/configure/migration-guide

[nelsonic]

[nelsonic]

> hapi-auth-jwt2@10.7.0 lint
> eslint lib

(node:49710) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.19.0

/hapi-auth-jwt2/eslint.config.js:1
import js from "@eslint/js";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at wrapSafe (node:internal/modules/cjs/loader:1378:20)
    at Module._compile (node:internal/modules/cjs/loader:1428:41)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async loadConfigFile (/Users/n/code/hapi-auth-jwt2/node_modules/eslint/lib/config/config-loader.js:197:21)

[nelsonic]

https://stackoverflow.com/questions/58211880/uncaught-syntaxerror-cannot-use-import-statement-outside-a-module-when-import

[nelsonic]

> hapi-auth-jwt2@10.7.0 lint
> eslint lib


/hapi-auth-jwt2/lib/extract.js
   3:16  error  'require' is not defined  no-undef
  27:1   error  'module' is not defined   no-undef
  64:15  error  'Buffer' is not defined   no-undef
  76:1   error  'module' is not defined   no-undef

/hapi-auth-jwt2/lib/index.js
   3:14  error  'require' is not defined             no-undef
   4:16  error  'require' is not defined             no-undef
   5:13  error  'require' is not defined             no-undef
   6:17  error  'require' is not defined             no-undef
   7:13  error  'require' is not defined             no-undef
  19:1   error  'exports' is not defined             no-undef
  20:22  error  'options' is defined but never used  no-unused-vars
  29:1   error  'exports' is not defined             no-undef
  35:1   error  'exports' is not defined             no-undef

✖ 13 problems (13 errors, 0 warnings)