Included changes from develop #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: format bignumber to engineering bug Add tests for correctly handling starting with more then 3 sig figs and targeting 1 or 2 sig figs * lint: * lint: reduce number literal sig figs * fix: engineering notation for bignumber input Corrects handling of cases where the input has 3 or more sig figs and the output is set to 1 or 2 sig figs. * test: add negative format bignumber precision test * fix: use BigNumber for all branches in toEngineering Also, remove string type option from JSDoc for toEngineering since string does support the required interface for the function (the .e property, .mul member function, and the .constructor property would not be correct after this change) * fix: precision 0 for fixed notation and bignumber This fix differentiates precision === 0 and precision === undefined to. After fix, format bignumber for precision 0 matches format number for precision 0. Tests added as well --------- Co-authored-by: Jos de Jong <[email protected]>
some additional unit tests, types and doc fix for distance function Co-authored-by: Jos de Jong <[email protected]>
…dian, mode, std, sum, prod, variance
* Included math to syntax when missing * Fixed examples in embedded docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.