Open
Conversation
markspanbroek
approved these changes
Mar 2, 2026
| trace "Errored slot is not in MySlots." | ||
| except CancelledError as e: | ||
| trace "SaleErrored.run was cancelled", error = e.msgDetail | ||
| trace "SaleErrored.isMySlot was cancelled", error = e.msgDetail |
Contributor
There was a problem hiding this comment.
Could also be the applyDelay that was cancelled
Contributor
Author
There was a problem hiding this comment.
This is true. I'll put it back to "run". Less informative, but better than providing details that may be incorrect.
Contributor
Author
|
Not ready for merge: I've made a system test for this recovery flow and it is not working. The asyncstatemachine.run is being used instead of the errored.nim one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RPC connection troubles occur, the sales state machine responds by moving to the Errored state. From there, slots are cleaned up and the flow ends.
This is undesirable for active slots, which the host should be storing and proving.
This PR introduces a new flow that allows active slots to recover from error state when connectivity is restored. It introduces an exponential-backoff module to protect against flooding the RPC connection.