fix: clarify order the directive

[7-zete-7]

Fixes #161 and fixes #92

Extends the default ordering to what FrankenPHP had before php/frankenphp#832.

I suggest a more correct location for the vulcain directive — after encode.

The current location (before request_header), I guess, was chosen for more correct request processing (to interact with unmodified request headers). I cannot judge the necessity of this.

The proposed location (after encode) should solve the response encoding error. This location was also chosen to avoid re-processing of Link headers by the push directive.

Expected change in the directive location

 tracing

 map
 vars
 fs
 root
 log_append
 log_skip
 log_name

 header
 copy_response_headers # only in reverse_proxy's handle_response block
 request_body

 redir

 # incoming request manipulation
 method
 rewrite
 uri
 try_files

 # middleware handlers; some wrap responses
 basic_auth
 forward_auth
-vulcain
 request_header
 encode
+vulcain
 push
 intercept
 templates

 # special routing & dispatching directives
 invoke
 handle
 handle_path
 route

 # handlers that typically respond to requests
 abort
 error
 copy_response # only in reverse_proxy's handle_response block
 respond
 metrics
 reverse_proxy
 php_fastcgi
 file_server
 acme_server

See Caddy's default directive order

[CLAassistant]

All committers have signed the CLA.

[henderkes]

@dunglas

[dunglas]

Thanks!