Unified code for DispatchQoS.QoSClass.description and qos_class_t.description#137
Merged
duemunk merged 2 commits intoduemunk:masterfrom May 21, 2019
RomanPodymov:feature/qos_class_description
Merged
Unified code for DispatchQoS.QoSClass.description and qos_class_t.description#137duemunk merged 2 commits intoduemunk:masterfrom RomanPodymov:feature/qos_class_description
duemunk merged 2 commits intoduemunk:masterfrom
RomanPodymov:feature/qos_class_description
Conversation
Owner
|
Looks good. Maybe the enum can be private? |
Owner
|
🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
In this pull request I added
QoSClassDescriptionto unify strings inDispatchQoS.QoSClass.descriptionandqos_class_t.description.I also removed
getin these computed properties.Please rename
QoSClassDescriptionand propose a better description for it if you want.