fix(bytes-str): Fix BytesString split_off char boundary#91
Merged
Conversation
|
(The deny failure should go away if you upgrade to version 2 of the action.) |
|
Are you planning to publish a new release with this? |
Member
Author
|
Yeap, I'll fix auto publishing of this repository once I get back to my PC. I thought f9ff0d8 would publish a new version. Thanks for the ping |
Member
Author
|
Done 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BytesString::split_offmutates its backing buffer.split_off.Why
BytesString::split_offcould split inside a UTF-8 code point, breaking the internal UTF-8 invariant and allowing safe APIs likeas_strto produce invalidstrdata.Fixes #90.
Validation
cargo fmt --check -p bytes-strcargo test -p bytes-str