Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: extern C and includes are not friends
Arrow submodule vendors in xxhash, and the vendored in apache-arrow does a funny:
Problem? This propagates C-linkage to the header, that then will eventually
#include <emscripten.h>, that since it relies on template code can't be compiled with C-linkage.xxhash should move includes outside of
extern Cbrackets, I will raise a bug report there.I am not sure/I don't see if situation can be detected / handled at the emscripten.h level. Basic open question is: can a header know it's being compiled within a
extern 'C'namespace?Solution: ... patches!
As always, adding more layers of patching solves (most) problems connected to customising submodules, at least in the short term. Here the patch explicitly includes emscripten.h outside of the extern C code.
I moved other patches from
duckdb_patchesto the more structuredpatches/duckdb, so that now also apatches/arrowcan be added.