hyper v1 upgrade

[zuisong]

No description provided.

[zuisong]

two test cases that cannot pass, I have already submitted an issue to reqwest.
seanmonstar/reqwest#2201

[blyxxyz]

xh does send Content-Length now even for GET requests. That seems weird since RFC 9110 says

A user agent SHOULD NOT send a Content-Length header field when the request message does not contain content and the method semantics do not anticipate such data.

It seems to be a bug? See seanmonstar/reqwest#2202 (comment). Notably this is causing real-world issues for someone, so we shouldn't send this header for GET requests if we can avoid it.

Otherwise we'd have to add it to the request headers that we print.

Test case

Run this in one terminal:

while nc -l -p 8080; do echo; done

Then run this in another:

cargo run -- -v :8080

This is what xh claims to send:

GET / HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate, br
Connection: keep-alive
Host: localhost:8080
User-Agent: xh/0.21.0

This is what's actually received:

GET / HTTP/1.1
Accept-Encoding: gzip, deflate, br
User-Agent: xh/0.21.0
Connection: keep-alive
Accept: */*
Host: localhost:8080
Content-Length: 0

[zuisong]

Thanks for pointing that out，I've submitted a PR to fix it.
seanmonstar/reqwest#2207

[blyxxyz]

This is very odd, but with your patched reqwest xh seems to send a body of 0 by default, i.e. the text 0. This is what I receive through netcat from xh post :8080:

POST / HTTP/1.1
Accept-Encoding: gzip, deflate, br
User-Agent: xh/0.21.0
Connection: keep-alive
Accept: */*
Host: localhost:8080
Transfer-Encoding: chunked

0

(or escaped: POST / HTTP/1.1\r\nAccept-Encoding: gzip, deflate, br\r\nUser-Agent: xh/0.21.0\r\nConnection: keep-alive\r\nAccept: */*\r\nHost: localhost:8080\r\nTransfer-Encoding: chunked\r\n\r\n0\r\n\r\n)

It doesn't happen if I comment out the reqwest patch in Cargo.toml.

(EDIT: this happens because reqwest chooses to use chunked transfer encoding.)

---

I've also noticed that with hyper v1 xh now errors if you override the Content-Length to be too large, e.g. xh post :8080 Content-Length:10. I don't think that's a big deal though, definitely not blocking for this PR.

[zuisong]

It's really weird. I'll keep looking for a solution.

[zuisong]

The issue is fixed now, could you check if there are other issues?

[blyxxyz]

Looks good!

[zuisong]

Reqwest just released a new version 0.12.3, so this PR can be ready to go