Return clickId when event already backfilled #2490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes introduce and update the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API (POST handler)
participant Tinybird Pipe
participant Redis
Client->>API (POST handler): Send payload with entries
API (POST handler)->>Tinybird Pipe: getFramerLeadEvents(linkIds)
Tinybird Pipe-->>API (POST handler): Return lead events for linkIds
loop For each payload entry
API (POST handler)->>Redis: Check if backfilled (externalId:eventName)
Redis-->>API (POST handler): Backfill status
alt Link missing
API (POST handler)-->>Client: Mark entry invalid (missing link)
else Already backfilled
API (POST handler)-->>Client: Mark entry invalid (already backfilled) + attach clickId
end
end
API (POST handler)-->>Client: Return results
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the backfill workflows to accept multiple link IDs and surfaces the clickId for events that have already been backfilled.
- Switches the Framer pipeline to use a
linkIdsparameter (string or array) in both scripts. - Returns
clickIdfor entries marked “Already backfilled.” in the batch route.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/scripts/framer/backfill-remainder.ts | Changed getFramerLeadEvents to take linkIds (string or array) and updated its invocation. |
| apps/web/app/(ee)/api/cron/framer/backfill-leads-batch/route.ts | Duplicated pipeline definition; added clickId to invalid entries and reordered checks. |
Comments suppressed due to low confidence (4)
apps/web/scripts/framer/backfill-remainder.ts:14
- Duplicate definition of
getFramerLeadEventspipeline appears in two locations; extracting this into a shared module (e.g.,lib/tinybird) would reduce code duplication and keep both callers in sync.
const getFramerLeadEvents = tb.buildPipe({
apps/web/scripts/framer/backfill-remainder.ts:19
- Consider adding unit tests for this transform to verify correct behavior when passing a single string, a comma-separated string, and an array of strings.
.transform((v) => (Array.isArray(v) ? v : v.split(",")))
apps/web/app/(ee)/api/cron/framer/backfill-leads-batch/route.ts:102
- [nitpick] Using
Array.mappurely for side effects can be misleading; switch toforEachor afor...ofloop to clarify intent.
originalPayload.map((p, index) => {
apps/web/app/(ee)/api/cron/framer/backfill-leads-batch/route.ts:120
- [nitpick] The message "Already backfilled." is rather generic; consider honing it (e.g., "Event already backfilled") and/or including the associated link ID for clearer debugging.
error: "Already backfilled.",
devkiran
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit