Fix default features in dependency#282
Merged
dtolnay merged 2 commits intodtolnay:masterfrom Jul 29, 2024
Merged
Conversation
Contributor
Author
|
Thank you for the crate |
|
Hello ! I think there is an issue with this. My Extract from my use case: [dependencies.ed25519-compact]
default-features = true
workspace = true
[workspace.dependencies.ed25519-compact]
version = "2.1.1"
default-features = false
features = ["std", "x25519"]In my setup, the CI use |
Contributor
Author
|
Indeed maybe default features should be an option of boolean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If in a crate
Cargo.tomlthere is a dependency withdefault-features = trueandworkspace = trueIf in the workspace
Cargo.tomlthe depended crate is written withdefault-features = falseThen we must serialize the
default-features = truewhen doing the manifest for the test.Otherwise the test will run with
default-features = falsewhich is not the expected behavior.