replaced get_current_week with value 0#49
Merged
dtcarls merged 1 commit intodtcarls:masterfrom Sep 13, 2019
ZachMyers3:master
Merged
replaced get_current_week with value 0#49dtcarls merged 1 commit intodtcarls:masterfrom ZachMyers3:master
dtcarls merged 1 commit intodtcarls:masterfrom
ZachMyers3:master
Conversation
Owner
|
After looking through the new API, all functions that currently use current week can take nothing for week number and is handled to be current week except for power_rankings. I may be cleaner to just get rid of the concept of current week in this bot and let the upstream API handle it. |
Author
|
There's other features as well, such as built-in power rankings from the API. I thought the same thing, but figured I'd submit this PR to fix the current issue at hand and go from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ff-espn-api has the ability to call the current week by passing a parameter of zero.
get_current_week was getting a week earlier than desired, so I've replaced all references of get_current_week() with a zero value.