Skip to content

add Landau-Lifschitz-Gilbert (LLG) simulation to magnetization module#164

Open
friweber wants to merge 10 commits intodschick:developfrom
friweber:LLG
Open

add Landau-Lifschitz-Gilbert (LLG) simulation to magnetization module#164
friweber wants to merge 10 commits intodschick:developfrom
friweber:LLG

Conversation

@friweber
Copy link
Copy Markdown

@friweber friweber commented Nov 26, 2024

add a new LLG class to the magnetization module which also provides a magneto-elastic coupling.

@friweber
Copy link
Copy Markdown
Author

I added the LL class where the shared functions of LLG and LLB are in. Than I added the LLG class. Running example is provided in the .ipynb

@dschick
Copy link
Copy Markdown
Owner

dschick commented Nov 26, 2024

Hi @friweber ,

thanks for the PR! Before going into detail, there are a lot of files which have changed in your commits (in total 21).
Somehow you have made alot of changes which are not relevant to the actual LLG simulation.

Could you please try to revert this and only have the relevant changes in your PR?

Best

Daniel

@friweber
Copy link
Copy Markdown
Author

Now it should be better. I don't understand why it shows a difference in upload-to-pypi.yml but all other issues are resolved

@dschick dschick changed the title added LLG add Landau-Lifschitz-Gilbert (LLG) simulation to magnetization module Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants